fix(ci): drop invalid --reload=file: from deno cache step - #1233
Conversation
Newer Deno (the CI pulls `deno-version: v2.x`) rejects a bare `file:` as a reload specifier: `error: invalid reload URL: 'file:'`, failing the "Setup deno" job on every run. The flag is also redundant — the preceding "Build Deno Module" step already runs `deno run --reload mod.ts`, so all deps are cached by the time this step runs; `deno cache ./mod.ts` just fetches anything still missing, which matches the step name. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Tagging OptionsShould a new tag be published when this PR is merged?
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe CI workflow no longer force-refreshes file dependencies during the Deno cache step. The command uses cached versions while preserving the lockfile and frozen-mode options. ChangesCI dependency cache
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized CI change removes an invalid Deno flag while preserving dependency caching, so no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
The Setup deno job fails on every run (main and PRs) with:
CI installs
deno-version: v2.x, which now resolves to a Deno that rejects a barefile:as a--reloadspecifier (older versions accepted it — runs from ~Aug 21 passed, runs after the Deno bump fail). Not tied to any source change; it broke on the toolchain upgrade.Fix
Drop
--reload=file:from the "fetch any uncached dependencies" step. It's redundant: the preceding Build Deno Module step already runsdeno run -A --reload mod.ts, so every dependency is cached by the time this step runs. Plaindeno cache ./mod.tsfetches anything still missing — exactly what the step name says — and works on all Deno versions.🤖 Generated with Claude Code
Summary by cubic
Fixes the CI "Setup deno" job that fails on every run when Deno v2.x rejects a bare
file:as a--reloadspecifier (invalid reload URL: 'file:'). Drops the--reload=file:flag from thedeno cachestep since the preceding build step already runsdeno run --reload mod.ts, and plaindeno cache ./mod.tsstill fetches anything missing.Written for commit 10ef850. Summary will update on new commits.
Summary by CodeRabbit