Skip to content

fix(ci): drop invalid --reload=file: from deno cache step - #1233

Merged
guitavano merged 1 commit into
mainfrom
fix/ci-invalid-reload-file
Aug 28, 2026
Merged

fix(ci): drop invalid --reload=file: from deno cache step#1233
guitavano merged 1 commit into
mainfrom
fix/ci-invalid-reload-file

Conversation

@guitavano

@guitavano guitavano commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Problem

The Setup deno job fails on every run (main and PRs) with:

Run deno cache --lock=deno.lock --frozen=false --reload=file: ./mod.ts
error: invalid reload URL: 'file:'
Error: Process completed with exit code 1.

CI installs deno-version: v2.x, which now resolves to a Deno that rejects a bare file: as a --reload specifier (older versions accepted it — runs from ~Aug 21 passed, runs after the Deno bump fail). Not tied to any source change; it broke on the toolchain upgrade.

Fix

Drop --reload=file: from the "fetch any uncached dependencies" step. It's redundant: the preceding Build Deno Module step already runs deno run -A --reload mod.ts, so every dependency is cached by the time this step runs. Plain deno cache ./mod.ts fetches anything still missing — exactly what the step name says — and works on all Deno versions.

🤖 Generated with Claude Code


Summary by cubic

Fixes the CI "Setup deno" job that fails on every run when Deno v2.x rejects a bare file: as a --reload specifier (invalid reload URL: 'file:'). Drops the --reload=file: flag from the deno cache step since the preceding build step already runs deno run --reload mod.ts, and plain deno cache ./mod.ts still fetches anything missing.

Written for commit 10ef850. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Chores
    • Improved dependency caching during continuous integration by avoiding unnecessary refreshes of already cached files.

Newer Deno (the CI pulls `deno-version: v2.x`) rejects a bare `file:` as a
reload specifier: `error: invalid reload URL: 'file:'`, failing the "Setup
deno" job on every run. The flag is also redundant — the preceding "Build Deno
Module" step already runs `deno run --reload mod.ts`, so all deps are cached by
the time this step runs; `deno cache ./mod.ts` just fetches anything still
missing, which matches the step name.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Tagging Options

Should a new tag be published when this PR is merged?

  • 👍 for Patch 1.210.1 update
  • 🎉 for Minor 1.211.0 update
  • 🚀 for Major 2.0.0 update

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 12930e1f-7bf2-4a7f-9a33-fafba407db2e

📥 Commits

Reviewing files that changed from the base of the PR and between 4e145ce and 10ef850.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The CI workflow no longer force-refreshes file dependencies during the Deno cache step. The command uses cached versions while preserving the lockfile and frozen-mode options.

Changes

CI dependency cache

Layer / File(s) Summary
Update Deno cache command
.github/workflows/ci.yaml
The dependency-fetch step removes the --reload=file: flag from deno cache. File dependencies can use cached versions.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 10ef8

This localized CI change removes an invalid Deno flag while preserving dependency caching, so no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the invalid --reload=file: option from the Deno cache step in CI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ci-invalid-reload-file

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@guitavano
guitavano merged commit a497514 into main Aug 28, 2026
8 checks passed
@guitavano
guitavano deleted the fix/ci-invalid-reload-file branch August 28, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant