Skip to content

feat(o11y): outgoing fetch metrics (counter + histogram) #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicacioliveira wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(o11y): outgoing fetch metrics (counter + histogram) #1155

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b80866
feat(o11y): add outgoing_fetch counter and duration histogram metrics
Apr 6, 2026
994e7dc
fix: disable outgoing fetch metrics by default, enable with OTEL_METR…
Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions observability/otel/metrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,33 @@ if (OTEL_IS_ENABLED) {
}

export const meter: IMeter = meterProvider.getMeter("deco");

// Outgoing fetch metrics — disabled by default. Enable with OTEL_METRICS_OUTGOING_FETCH=true.
import { ValueType } from "../../deps.ts";
import { onFetch, parseUrlParts } from "../../utils/patched_fetch.ts";

if (Deno.env.get("OTEL_METRICS_OUTGOING_FETCH") === "true") {

@cubic-dev-ai cubic-dev-ai Bot Apr 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Outgoing fetch metrics are now gated by OTEL_METRICS_OUTGOING_FETCH, which disables the feature by default instead of keeping it always-on.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At observability/otel/metrics.ts, line 71:

<comment>Outgoing fetch metrics are now gated by `OTEL_METRICS_OUTGOING_FETCH`, which disables the feature by default instead of keeping it always-on.</comment>

<file context>
@@ -64,10 +64,12 @@ if (OTEL_IS_ENABLED) {
 import { ValueType } from "../../deps.ts";
 import { onFetch, parseUrlParts } from "../../utils/patched_fetch.ts";
 
+if (Deno.env.get("OTEL_METRICS_OUTGOING_FETCH") === "true") {
+
 const fetchCount = meter.createCounter("outgoing_fetch", {
</file context>
Fix with Cubic


const fetchCount = meter.createCounter("outgoing_fetch", {
unit: "1",
valueType: ValueType.INT,
});

const fetchDuration = meter.createHistogram("outgoing_fetch_duration", {
unit: "ms",
valueType: ValueType.DOUBLE,
});

onFetch((event) => {
const { host } = parseUrlParts(event.url);
const attrs = {
app: event.app ?? "unknown",
host: host ?? "unknown",
method: event.method,
status: event.status,
};
fetchCount.add(1, attrs);
fetchDuration.record(event.durationMs, attrs);
});

} // OTEL_METRICS_OUTGOING_FETCH
Loading