Skip to content

style(vnda): fix deno fmt CI failure in productListingPage loader#1615

Merged
vibe-dex merged 1 commit into
mainfrom
vibe-dex/fix-vnda-fmt-error
Jun 19, 2026
Merged

style(vnda): fix deno fmt CI failure in productListingPage loader#1615
vibe-dex merged 1 commit into
mainfrom
vibe-dex/fix-vnda-fmt-error

Conversation

@vibe-dex

@vibe-dex vibe-dex commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

What

Applies deno fmt to vnda/loaders/productListingPage.ts, fixing the deno fmt --check CI failure introduced by #1563.

Why

The format check job was failing with Found 1 not formatted file. The reformatting is purely cosmetic (param wrapping, .split("/") line break, arrow body, trailing newline) — no logic changes.

Verification

deno fmt --check vnda/loaders/productListingPage.ts
# Checked 1 file

🤖 Generated with Claude Code


Summary by cubic

Applies deno fmt to vnda/loaders/productListingPage.ts to fix the deno fmt --check CI failure introduced by #1563. Formatting only; no logic changes.

Written for commit d1d4815. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Style
    • Improved code formatting and line-wrapping in internal modules for better readability.

Note: This release contains no user-visible changes.

Fixes the `deno fmt --check` CI failure left by #1563. Pure formatting,
no logic changes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Tagging Options

Should a new tag be published when this PR is merged?

  • 👍 for Patch 0.158.1 update
  • 🎉 for Minor 0.159.0 update
  • 🚀 for Major 1.0.0 update

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2f879dc2-559f-4ccb-83e1-ae55d60b5409

📥 Commits

Reviewing files that changed from the base of the PR and between f7cbcd6 and d1d4815.

📒 Files selected for processing (1)
  • vnda/loaders/productListingPage.ts

📝 Walkthrough

Walkthrough

Purely cosmetic reformatting of vnda/loaders/productListingPage.ts: line breaks are adjusted in the parseTypeTagsFromUrl function signature and in the categoryTagName/uniquePathNames derivation block inside searchLoader. No logic, types, or exports change.

Changes

Formatting cleanup in productListingPage.ts

Layer / File(s) Summary
Whitespace reformatting
vnda/loaders/productListingPage.ts
Line-wrapping adjusted for parseTypeTagsFromUrl's parameter/return type and for the categoryTagName/uniquePathNames construction (including the typeof item === "string" type guard); export default searchLoader is untouched.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit combed the code one night,
And nudged the lines to sit just right.
No logic changed, no bug took flight,
Just whitespace wrapped in tidy light.
🐇 ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: applying deno fmt formatting to fix a CI failure in the productListingPage loader file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vibe-dex/fix-vnda-fmt-error

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@vibe-dex vibe-dex merged commit d95c572 into main Jun 19, 2026
8 checks passed
@vibe-dex vibe-dex deleted the vibe-dex/fix-vnda-fmt-error branch June 19, 2026 17:02
vibe-dex added a commit that referenced this pull request Jun 19, 2026
Triggers a version bump for the changes already merged to main:
- #1563 optimize /api/v2/tags/:name calls to prevent rate limiting on PLP loader
- #1615 deno fmt fix for the PLP loader

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant