feat: eslint standard with trailing commas#67
Open
ekoeryanto wants to merge 3 commits intodecaporg:masterfrom
Open
feat: eslint standard with trailing commas#67ekoeryanto wants to merge 3 commits intodecaporg:masterfrom
ekoeryanto wants to merge 3 commits intodecaporg:masterfrom
Conversation
Contributor
|
Awesome, thanks for this @ekoeryanto - do we pass linting currently? If you add a lint task and have it run before builds we can take a look at the results. |
Contributor
Author
|
yes we pass the lint currently, but i missing the and yes, I also missing the npm script there, I'll try to add the lint task and make it run before build |
Contributor
|
That'd be great, thanks! |
Contributor
Author
|
the |
Contributor
|
I'd say so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.