NuoDB Producer

[jazd]

Create NuoDB DDL from XML-SQLFairy, NuoDB Producer.

It works good enough for my current use, but I am willing to maintain and continue to submit improvements.

[ribasushi]

Hello @jazd, sorry for not getting to you earlier. The patch looks relatively good (your starting point (...DB2.pm) isn't great, but that isn't your fault in any way).

Do you happen to have any plans on making a ::Parser counterpart to this (and checking whether it properly roundtrips via t/60roundtrip.t)? If not I suppose we will merge the thing as-is, and call it good. But if you were planning on adding a grammar to this, it would be much much better to get the changes in as a "package", as this will undoubtedly catch yet-unknown issues.

[jazd]

@ribasushi I do not have any plans to produce a ::Parser. If one is needed by others in the future, I am willing to work on it. All of my schemata start out in XML-SQLFairy format :)

[jazd]

@ribasushi please merge as-is.

[jazd]

I am referencing sql-translator in my https://github.com/jazd/Business project. I made it public today. sql-translator is required to build the project from source.

[ribasushi]

Hello @jazd
Apologies for the slow response on this.

Given that SQLT is generally moving in the direction of "less kitchen sinks", and an upcoming release will (try to) make this distinction more prominent, I think it would be more conductive to release this producer as a standalone CPAN module with a dependency on SQL::Translator.

This way you both get to develop it on an independent schedule, and the sprawling growth of the core SQLT dist won't continue.

I am not saying strictly "this won't merge", nor am I closing this ticket yet. I want to hear your thoughts on that first.

[jazd]

@ribasushi,

I would rather this producer be included before you make such a move. If you decide to pull out a group of Producers and Parsers at a later date, we can revisit if NuoDB should be on that list.

There are so few SQL database servers in the world, are you sure this move is necessary? Also, is sqlt useful on its own, without the producers/parsers?

[ribasushi]

Fair enough (and this is why I wanted to wait to hear from you). I will do a final review and add, hopefully as soon as this weekend.

[jazd]

Thank you :)
I have now released my schema with a NuoDB target https://github.com/jazd/Business/releases/tag/0.0.2

[jazd]

The travis-ci failures are due to build script issues in Perl 5.8 and Perl blead system installation and setup prior to running any tests.

@ribasushi Hope all else is well. Please merge as-is.

[ribasushi]

@jazd Hi!

A series of not-so-recent events are preventing me from using my PAUSE account, so I had to suspend work on everything I used to maintain.

It seems like a resolution is finally within reach, but even when everything is settled it will take a while for me to unwind the piled up todo-list. In the meantime all I can suggest is contacting the current DBIC/SQLT/SQLA management on IRC.

I am sorry your contribution got caught up in this policy dispute. Hoping the freeze on my side won't last too long into the future.

Cheers!

[jazd]

@ribasushi Hello!
Thank you for the update. I am not in a huge hurry, so, for now, I will wait it out here with you.
Let me know if I can help with anything.
-Steve

[jazd]

@ribasushi can someone please re-run the build for this PR?
The original #230 failed due to what looked like a tool failure.

[codecov]

Codecov Report

Merging #71 into master will increase coverage by 0.29%.
The diff coverage is 79.61%.

@@            Coverage Diff            @@
##           master     #71      +/-   ##
=========================================
+ Coverage    21.5%   21.8%   +0.29%     
=========================================
  Files          71      72       +1     
  Lines       19914   20017     +103     
  Branches     5728    5751      +23     
=========================================
+ Hits         4283    4365      +82     
- Misses      14922   14933      +11     
- Partials      709     719      +10

Impacted Files	Coverage Δ
lib/SQL/Translator/Producer/NuoDB.pm	79.61% <79.61%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86c68a0...2767a07. Read the comment docs.

[jazd]

@ilmari would it be possible to accept and merge my pull request?

[shadowcat-mst]

@jazd the database looks really interesting but I'm not sure why you were being strung along with "maybe we'll merge it" when so far as I can tell this would 100% work fine as a standalone cpan module and then you wouldn't have to wait for us.

Is there a reason you wanted it in core rather than installable? If not, can I help you figure out how to get it onto CPAN in an orderly fashion?

[jazd]

@shadowcat-mst sure, I would appreciate assistance in making this installable if this will never be merged. I am willing to wait longer ;-)

[shadowcat-mdk]

@jazd Maybe you want to tag @shadowcat-mst in that reply and not me :)