Feat/charts improvements#1088
Open
nicolaskempf57 wants to merge 18 commits into
Open
Conversation
The ChartConfigurator component was updated to require selecting: 1. Producer (via ProducerSelect) 2. Dataset (via SearchableSelect) 3. Resource (via standard select) Before the chart configuration form (title, description, etc.) appears. Additionally, some form elements changed from standard selects to custom components: - Chart type: now uses Listbox component - X-axis column: now uses SearchableSelect - Y-axis column: now uses SearchableSelect This commit updates all 25 tests to: - Use a new setupChart() helper function that performs the required setup steps - Use appropriate selectors for Listbox (click button, select by text) - Use appropriate selectors for SearchableSelect (click input, select by text) - Keep existing selectors for standard form elements
nicolaskempf57
requested review from
ThibaudDauce and
maudetes
and removed request for
ThibaudDauce
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes datagouv/data.gouv.fr#2014