Refonte UI compte / habilitations#137
Draft
skelz0r wants to merge 4 commits into
Draft
Conversation
Replace the 4-column table (habilitation, token, actions, detail) with a responsive grid of DSFR cards showing title, status badge, DataPass reference and user role label. - Switch eager loading from :active_token to :user_authorization_request_roles (fixes N+1 for role display) - Filter roles in Ruby on the preloaded collection instead of hitting the DB per row - Load @tokens (all tokens) in show action instead of @main_token + @other_tokens (preparation for show redesign) - Rewrite index feature spec to match the new card-based UI
Remove mono-token-centric UI and redundant sections: - Remove summary sidebar (sticky navigation) - Remove scopes/access rights section (available on DataPass) - Remove "main token" reveal/prolong/prolongation workflow - Remove attestations download section - Add prominent DataPass link button (fr-btn--lg) - Replace token sections with a single table listing all tokens with actions: reveal, transfer and stats links - Simplify contacts as an inline list with a DataPass edit link - Keep delegations section unchanged Adapt show spec and shared magic link spec to match new UI.
The viewable_by_users scope now filters out refused requests. These are not actionable by users and add noise to the list. Users can still see refused requests on DataPass directly.
Create a "Mairie de Nantes" authorization request (external_id 107) where contact_technique@yopmail.com is the demandeur and user@yopmail.com is only contact_technique. This allows testing the UI from a non-demandeur perspective. Also extract user creation into a dedicated create_users method to keep perform under the method length limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.