Skip to content

chore: pull latest translations from Transifex (50%+ complete)#763

Merged
bfoss765 merged 1 commit intomasterfrom
v8.5.5-translations
Mar 25, 2026
Merged

chore: pull latest translations from Transifex (50%+ complete)#763
bfoss765 merged 1 commit intomasterfrom
v8.5.5-translations

Conversation

@bfoss765
Copy link
Copy Markdown
Contributor

@bfoss765 bfoss765 commented Mar 24, 2026

Update 21 language files and Japanese App Store metadata from Transifex.

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Documentation
    • Updated German localization for merchant display text.
    • Refined Japanese app description formatting for improved readability.

Update 21 language files and Japanese App Store metadata from Transifex.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 24, 2026

📝 Walkthrough

Walkthrough

This PR makes minor updates to localization and app store metadata: correcting a format specifier in German pluralization strings and adjusting whitespace formatting in Japanese app store description bullet points.

Changes

Cohort / File(s) Summary
Localization & Metadata Updates
DashWallet/de.lproj/Localizable.stringsdict, fastlane/metadata/ja/description.txt
German pluralization format specifier correction in merchant count string; Japanese metadata whitespace normalization in bullet points.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A comma here, a space removed,
Strings and metadata smoothly grooved,
German merchants now align,
Japanese bullets looking fine,
Small tweaks make the app divine! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: pulling latest translations from Transifex with a note on completion percentage.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch v8.5.5-translations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
fastlane/metadata/ja/description.txt (1)

13-17: Keep bullet marker spacing consistent in this list block.

Line 13, Line 15, and Line 17 use * without a space, while adjacent items use * . Please normalize these for consistency across the App Store description.

Proposed normalization
-*顔認証で速やかな支払い
+* 顔認証で速やかな支払い
-*ユーザーのDashの売買を可能にするサードパーティの統合
+* ユーザーのDashの売買を可能にするサードパーティの統合
-*様々なカスタムセキュリティに対する志向に対応する柔軟な設定
+* 様々なカスタムセキュリティに対する志向に対応する柔軟な設定
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@fastlane/metadata/ja/description.txt` around lines 13 - 17, Normalize the
bullet marker spacing in the App Store description by ensuring every list item
uses "* " (asterisk followed by a space); update the lines that currently start
with "*" without a space (the items beginning with "顔認証で速やかな支払い",
"ユーザーのDashの売買を可能にするサードパーティの統合", and "様々なカスタムセキュリティに対する志向に対応する柔軟な設定") to use "* "
so all bullets match the adjacent items in description.txt.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@DashWallet/de.lproj/Localizable.stringsdict`:
- Around line 32-34: Replace the invalid placeholder "&@" in the German plural
strings that currently read "%d Händler in &@" with the correct
Objective‑C/Swift string placeholder "%@" so the second argument (distance
string) is interpolated; locate the entries where the literal "%d Händler in &@"
appears in Localizable.stringsdict and update both plural forms (the two
occurrences shown) to "%d Händler in %@".

---

Nitpick comments:
In `@fastlane/metadata/ja/description.txt`:
- Around line 13-17: Normalize the bullet marker spacing in the App Store
description by ensuring every list item uses "* " (asterisk followed by a
space); update the lines that currently start with "*" without a space (the
items beginning with "顔認証で速やかな支払い", "ユーザーのDashの売買を可能にするサードパーティの統合", and
"様々なカスタムセキュリティに対する志向に対応する柔軟な設定") to use "* " so all bullets match the adjacent
items in description.txt.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cc9c5764-1a03-42c4-8777-a4ac85402776

📥 Commits

Reviewing files that changed from the base of the PR and between 21e7860 and 239ecee.

📒 Files selected for processing (22)
  • DashWallet/de.lproj/Localizable.strings
  • DashWallet/de.lproj/Localizable.stringsdict
  • DashWallet/el.lproj/Localizable.strings
  • DashWallet/es.lproj/Localizable.strings
  • DashWallet/fa.lproj/Localizable.strings
  • DashWallet/fil.lproj/Localizable.strings
  • DashWallet/fr.lproj/Localizable.strings
  • DashWallet/id.lproj/Localizable.strings
  • DashWallet/it.lproj/Localizable.strings
  • DashWallet/ja.lproj/Localizable.strings
  • DashWallet/ko.lproj/Localizable.strings
  • DashWallet/nl.lproj/Localizable.strings
  • DashWallet/pl.lproj/Localizable.strings
  • DashWallet/pt.lproj/Localizable.strings
  • DashWallet/ru.lproj/Localizable.strings
  • DashWallet/sk.lproj/Localizable.strings
  • DashWallet/th.lproj/Localizable.strings
  • DashWallet/tr.lproj/Localizable.strings
  • DashWallet/uk.lproj/Localizable.strings
  • DashWallet/zh.lproj/Localizable.strings
  • DashWallet/zh_TW.lproj/Localizable.strings
  • fastlane/metadata/ja/description.txt

Comment thread DashWallet/de.lproj/Localizable.stringsdict
Copy link
Copy Markdown
Contributor

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pull text to fix the one item in German that is incorrect

Comment thread DashWallet/de.lproj/Localizable.stringsdict
Comment thread DashWallet/de.lproj/Localizable.stringsdict
Copy link
Copy Markdown
Contributor

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bfoss765 bfoss765 merged commit bce2e51 into master Mar 25, 2026
2 checks passed
@bfoss765 bfoss765 deleted the v8.5.5-translations branch March 25, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants