feature: PiggyCards fixed denomination cards and version bump to 8.5.1

[bfoss765]

Summary

• Fix PiggyCards fixed denomination gift cards to show all available denominations (e.g., Netflix shows $20, $25, $50 instead of just $25)
• Display per-card discount instead of highest discount across all cards
• Show cost message with discount for fixed denomination cards
• Fix percentage formatting to show decimals when needed (e.g., 13.5% instead of 14%)
• Bump version to 8.5.1

Changes

DashSpendPayViewModel.swift

• Aggregate denominations from ALL gift cards returned by PiggyCards API
• Track discount per denomination using denominationDiscounts dictionary
• Update savingsFraction when user selects a denomination
• Fix showCost to display cost message for fixed denomination cards

DashSpendConfirmationDialog.swift

• Use PercentageFormatter instead of .intValue for discount display

PercentageFormatter.swift

• Show decimals when percentage value has a fractional part

project.pbxproj

• Bump MARKETING_VERSION from 8.5.0 to 8.5.1 across all targets

Test plan

• Verify Netflix shows $20, $25, $50 denomination buttons
• Verify Amazon shows $50, $100, $500 denomination buttons
• Verify eBay shows $50, $100, $500 denomination buttons
• Verify DoorDash shows $50, $100 denomination buttons
• Verify Uber shows $50, $100 denomination buttons
• Verify Target shows $50, $100, $500 denomination buttons
• Verify selecting different denominations updates the discount display
• Verify cost message appears when denomination is selected
• Verify percentage shows decimal (e.g., 13.5%) on enter amount screen
• Verify percentage shows decimal on confirmation dialog

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/PC-fixed-card-fixes

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[HashEngineering]

LGTM