Skip to content

fix(ci): derive version from Cargo.toml in release artifacts #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lklimek merged 6 commits into from
Mar 30, 2026
Merged

fix(ci): derive version from Cargo.toml in release artifacts #804

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c90bf7c
fix(ci): derive version from Cargo.toml in release artifacts
lklimek Mar 30, 2026
2e840c3
fix(ci): harden version extraction and fix macOS plist format
lklimek Mar 30, 2026
45df8c5
fix(ci): use cargo metadata instead of grep for version extraction
lklimek Mar 30, 2026
8f9eac4
fix(ci): harden plist version validation and use release date for Fla…
lklimek Mar 30, 2026
01b7f88
fix(ci): use CI run number for CFBundleVersion build number
lklimek Mar 30, 2026
21fae07
fix(ci): harden workflow ordering and quoting
lklimek Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/flatpak.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,14 @@ jobs:
- name: Check out code
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

- name: Sync metainfo version from Cargo.toml
run: |
VERSION=$(grep '^version = ' Cargo.toml | head -1 | sed 's/version = "\(.*\)"/\1/')
DATE=$(date +%Y-%m-%d)
Comment thread
lklimek marked this conversation as resolved.
Outdated
sed -i "s|<release version=\"[^\"]*\" date=\"[^\"]*\"|<release version=\"${VERSION}\" date=\"${DATE}\"|" \
flatpak/org.dash.DashEvoTool.metainfo.xml
echo "Metainfo version set to ${VERSION}, date ${DATE}"

Comment thread
coderabbitai[bot] marked this conversation as resolved.
- name: Install Flatpak and Flatpak Builder
run: |
sudo apt-get update
Expand Down
20 changes: 16 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,12 @@ jobs:
- name: Check out code
uses: actions/checkout@v4

- name: Extract version from Cargo.toml
id: version
run: |
VERSION=$(grep '^version = ' Cargo.toml | head -1 | sed 's/version = "\(.*\)"/\1/')
echo "version=$VERSION" >> $GITHUB_OUTPUT

Comment thread
coderabbitai[bot] marked this conversation as resolved.
- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@stable

Expand Down Expand Up @@ -270,9 +276,9 @@ jobs:
<key>CFBundleDisplayName</key>
<string>Dash Evo Tool</string>
<key>CFBundleVersion</key>
<string>1.0.0</string>
<string>${{ steps.version.outputs.version }}</string>
Comment thread
lklimek marked this conversation as resolved.
Outdated
<key>CFBundleShortVersionString</key>
<string>1.0.0</string>
<string>${{ steps.version.outputs.version }}</string>
Comment thread
lklimek marked this conversation as resolved.
Outdated
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleSignature</key>
Expand Down Expand Up @@ -468,6 +474,12 @@ jobs:
- name: Check out code
uses: actions/checkout@v4

- name: Extract version from Cargo.toml
id: version
run: |
VERSION=$(grep '^version = ' Cargo.toml | head -1 | sed 's/version = "\(.*\)"/\1/')
echo "version=$VERSION" >> $GITHUB_OUTPUT

- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@stable

Expand Down Expand Up @@ -563,9 +575,9 @@ jobs:
<key>CFBundleDisplayName</key>
<string>Dash Evo Tool</string>
<key>CFBundleVersion</key>
<string>1.0.0</string>
<string>${{ steps.version.outputs.version }}</string>
<key>CFBundleShortVersionString</key>
<string>1.0.0</string>
<string>${{ steps.version.outputs.version }}</string>
Comment thread
lklimek marked this conversation as resolved.
Outdated
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleSignature</key>
Expand Down
1 change: 1 addition & 0 deletions flatpak/org.dash.DashEvoTool.metainfo.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
<name>Dash Core Group</name>
</developer>

<!-- Version and date are auto-synced from Cargo.toml by CI (flatpak.yml) -->
<releases>
<release version="1.0.0-dev" date="2026-02-17" type="development" />
</releases>
Expand Down
Loading