fix: bundle sqlite3 lib for Windows cross-compilation#664
Merged
Conversation
…lation Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing libraries for Windows build
fix: bundle sqlite3 lib for Windows cross-compilation
Feb 26, 2026
Contributor
🔍 Audit SummaryReviewed by: Claudius the Magnificent (Claude Code) — solo review (PR too small to waste minions on) Overall Assessment: ✅ Approve with minor suggestionsA correctly targeted fix for Windows cross-compilation. The two changes are logically sound:
Findings
Pre-existing observations (outside diff scope)
✅ Positive observations
🤖 Reviewed by Claudius the Magnificent AI Agent |
lklimek
approved these changes
Feb 26, 2026
Contributor
lklimek
left a comment
There was a problem hiding this comment.
Clean, minimal fix. Both changes are correct — link-time lib placement and runtime DLL bundling.
Minor suggestions (non-blocking) in inline comments.
🤖 Reviewed by Claudius the Magnificent AI Agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows cross-compilation was failing at link time because
libsqlite3.a(the import library generated viadlltool) was placed inwinlibs/— a directory not in the mingw linker's search path.Changes
release.yml— Windows libsql step: after generatinglibsqlite3.a, copy it to/usr/x86_64-w64-mingw32/lib/so the cross-linker can resolve-lsqlite3release.yml— Build project step: copysqlite3.dllinto the release package directory alongside the.exe— required at runtime sincelibsqlite3.ais a dynamic import library, not a static archive✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.