Skip to content

fix: build fails for windows target #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PastaPastaPasta merged 10 commits into from
Feb 9, 2026
Merged

fix: build fails for windows target #527

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
456f88e
fix: build fails for windows target
lklimek Feb 4, 2026
1014158
build: only create a release when tag is set
lklimek Feb 4, 2026
98b660d
chore: remove redundant settings from release.yml
lklimek Feb 4, 2026
ca0d42f
doc: windows requirements
lklimek Feb 4, 2026
b058fd3
fix: windows icon
lklimek Feb 4, 2026
72bc365
Merge remote-tracking branch 'origin/v1.0-dev' into build/fix-windows…
lklimek Feb 4, 2026
77a5b51
build: change grovestark revision
lklimek Feb 4, 2026
4fd1be3
chore: fmt
lklimek Feb 4, 2026
ab6dad3
fix: don't open console window on windows
lklimek Feb 4, 2026
c74897b
build: grovestark recent commit
lklimek Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,12 @@ rustflags = ["-C", "target-feature=-crt-static", "-C", "target-cpu=x86-64"]

[target.x86_64-unknown-linux-gnu]
rustflags = ["-C", "target-feature=-crt-static", "-C", "target-cpu=x86-64"]

[target.x86_64-pc-windows-gnu]
linker = "x86_64-w64-mingw32-gcc-posix"
ar = "x86_64-w64-mingw32-ar"

[env]
CC_x86_64_pc_windows_gnu = "x86_64-w64-mingw32-gcc-posix"
CXX_x86_64_pc_windows_gnu = "x86_64-w64-mingw32-g++-posix"
AR_x86_64_pc_windows_gnu = "x86_64-w64-mingw32-ar"
Comment thread
lklimek marked this conversation as resolved.
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
inputs:
tag:
description: "Version (i.e. v0.1.0)"
required: true
required: false
Comment thread
lklimek marked this conversation as resolved.

permissions:
id-token: write
Expand Down Expand Up @@ -700,6 +700,7 @@ jobs:
uses: softprops/action-gh-release@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
if: ${{ github.event.inputs.tag != '' }}
with:
tag_name: ${{ github.event.inputs.tag }}
files: |
Expand Down
Loading