Skip to content

Add flatten functionality - flattens Multi* geometries to their single counterparts#246

Open
Newmanjack wants to merge 10 commits intodartclub:mainfrom
deanpapas:Flatten
Open

Add flatten functionality - flattens Multi* geometries to their single counterparts#246
Newmanjack wants to merge 10 commits intodartclub:mainfrom
deanpapas:Flatten

Conversation

@Newmanjack
Copy link
Copy Markdown

No description provided.

@hamishdgx hamishdgx self-assigned this Mar 26, 2026
@hamishdgx
Copy link
Copy Markdown
Contributor

I've moved the tests into components and added MOST of the tests from turfJS.
Do we remember why GeometryCollection is not supported????

@hamishdgx hamishdgx added the RMITWeek1 RMIT2026 label Mar 26, 2026
@hamishdgx hamishdgx requested review from hamishdgx and lukas-h March 26, 2026 23:10
Comment thread lib/src/booleans/boolean_contains.dart Outdated
bbox1[2]! < bbox2[2]! ||
bbox1[1]! > bbox2[1]! ||
bbox1[3]! < bbox2[3]!) return false;
bbox1[3]! < bbox2[3]!) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this will work - I am a bit sceptical though, because the third parameters (Altitude) are optional in coordinates and bounding boxes. Can you verify this?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this based on the analyze output. I'll verify it works now :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I am going to need a hand with the logic of this. I will book in a time with you.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e01ae9d - should fix this. From everything I've tested it seems 4- and 6-number BBox values both use the correct longitudes and latitudes like this.

Comment thread lib/src/flatten.dart Outdated
Comment thread Progress.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RMITWeek1 RMIT2026

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants