Conversation
|
I reviewed the randomPosition implementation locally and the related tests are passing on my side. I also added validation coverage for null bbox handling. |
Ran dart format on the codebase and pushed the changes. |
| /// ``` | ||
| bool booleanDisjoint(GeoJSONObject feature1, GeoJSONObject feature2, {bool ignoreSelfIntersections = false}) { | ||
| bool booleanDisjoint(GeoJSONObject feature1, GeoJSONObject feature2, | ||
| {bool ignoreSelfIntersections = false}) { |
There was a problem hiding this comment.
you can add a trailing comma after the = false,} and then it will auto-formart it for you
| bool booleanDisjoint(GeoJSONObject feature1, GeoJSONObject feature2, {bool ignoreSelfIntersections = false}) { | ||
| bool booleanDisjoint(GeoJSONObject feature1, GeoJSONObject feature2, | ||
| {bool ignoreSelfIntersections = false}) { | ||
| var bool = true; |
There was a problem hiding this comment.
maybe you should give this variable a different name to avoid a name collision with the bool type
| if (bbox.length != 4) { | ||
| throw ArgumentError("Bbox must contain exactly 4 values."); | ||
| } |
There was a problem hiding this comment.
our bboxes could also contain 6 values if altitudes are provided
Not entirely sure if this applied to here though
There was a problem hiding this comment.
Could be 6 if includes alts
|
@haozeguo Changes requested. Please address |
|
thanks
获取 Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
发件人: Hamish Dean-Graham ***@***.***>
发送时间: Monday, April 13, 2026 12:12:52 PM
收件人: dartclub/turf_dart ***@***.***>
抄送: Haoze Guo ***@***.***>; Mention ***@***.***>
主题: Re: [dartclub/turf_dart] Feature random position (PR #238)
[https://avatars.githubusercontent.com/u/87750405?s=20&v=4]hamishdgx left a comment (dartclub/turf_dart#238)<#238 (comment)>
@haozeguo<https://github.com/haozeguo> Changes requested. Please address
―
Reply to this email directly, view it on GitHub<#238 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BCX7HTISNSYBHG6BC6DO2X34VREKJAVCNFSM6AAAAACW3SHHXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DEMZTGM2DKMBSGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
4 participants
implementation of randomPosition. slight differences to turfJS (turf has all random functions in one file - these are being done in separate files)