-
Notifications
You must be signed in to change notification settings - Fork 50
Nullable dataset ext #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fsw
wants to merge
10
commits into
dart-lang:main
Choose a base branch
from
fsw:nullable-dataset-ext
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Nullable dataset ext #507
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
37f8f5d
nullable dataset extension
fsw 7b4dd78
nullable dataset, use diferent extension type instead of wrapper, sup…
fsw 1b07fda
typo
fsw 4d471ba
extend dataset tests to include svg element
fsw d839bd9
link to wrapped property
fsw 6fef4e5
cr fixes, add data to MathMLElement, fix comments
fsw 0b3aee9
dartdoc fix
fsw 897d30a
allow deletion of dataset by setting null
fsw f994aad
docs
fsw 139d0ed
year
fsw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file | ||
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| import 'dart:js_interop'; | ||
| import 'dart:js_interop_unsafe'; | ||
|
|
||
| import '../dom/html.dart'; | ||
| import '../dom/mathml_core.dart'; | ||
| import '../dom/svg.dart'; | ||
|
|
||
| /// Provides nullable api on `DOMStringMap`. | ||
| /// Native `DOMStringMap` returns non nullable `DOMString` from getter and | ||
| /// returns `undefined` when given key does not exist. As in Dart there is no | ||
| /// `undefined`, this wrapper will return null in such case. | ||
| /// This extension also allows removing `dataset` elements. | ||
| extension type NullableDOMStringMap._(JSObject _) implements JSObject { | ||
| /// Retrieves `dataset` element. | ||
| /// When it is not set (`data-*` attribute is missing) returns null. | ||
|
fsw marked this conversation as resolved.
Outdated
|
||
| external String? operator [](String name); | ||
|
|
||
| external void operator []=( | ||
| String name, | ||
| String value, | ||
|
fsw marked this conversation as resolved.
Outdated
|
||
| ); | ||
|
|
||
| /// Removes `dataset` element (and corresponding `data-*` attribute) | ||
| String? remove(String name) { | ||
| final ret = this[name]; | ||
| delete(name.toJS); | ||
| return ret; | ||
| } | ||
| } | ||
|
|
||
|
fsw marked this conversation as resolved.
|
||
| extension HTMLElementDatasetExtension on HTMLElement { | ||
| /// Wrapper for nullable [dataset]. See [NullableDOMStringMap] for details. | ||
| @JS('dataset') | ||
| external NullableDOMStringMap get data; | ||
| } | ||
|
|
||
| extension SVGElementDatasetExtension on SVGElement { | ||
| /// Wrapper for nullable [dataset]. See [NullableDOMStringMap] for details. | ||
| @JS('dataset') | ||
| external NullableDOMStringMap get data; | ||
| } | ||
|
|
||
| extension MathMLElementDatasetExtension on MathMLElement { | ||
| /// Wrapper for nullable [dataset]. See [NullableDOMStringMap] for details. | ||
| @JS('dataset') | ||
| external NullableDOMStringMap get data; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.