fix: remove tags when deleting metrics (close #70)#75
Merged
daniil-berg merged 3 commits intomainfrom Apr 2, 2026
Merged
Conversation
daniil-berg
reviewed
Apr 1, 2026
Owner
daniil-berg
left a comment
daniil-berg
left a comment
There was a problem hiding this comment.
Great addition and especially because you cover it with a test. :)
Can you just replace the qualified names with imports?
This test is about the deletion of the metric and not its creation, so adding the metric to the database is the test setup and thus done manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test case confirming the issue described in #70 and implements a straightforward fix for it.