Stop TimeZoneNotFoundException from being thrown every tick#141
Merged
Conversation
The TimeZoneInfo settings getter used a caught TimeZoneNotFoundException as its fallback path, and the default TimeZone setting is an empty string, so every read threw. The format editor preview reads it on a one-second timer, spamming first-chance exceptions in the debugger. Return Local directly for an empty ID, cache the resolved zone per ID so an invalid ID throws once instead of every second, and also handle InvalidTimeZoneException for corrupt registry data.
Signed-off-by: Daniel Chalmers <daniel.chalmers@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings.TimeZoneInfono longer relies on a caughtTimeZoneNotFoundExceptionas its normal fallback path:TimeZoneID (the default) now returnsTimeZoneInfo.Localdirectly without callingFindSystemTimeZoneById.InvalidTimeZoneException, whichFindSystemTimeZoneByIdcan throw for corrupt registry data.TimeZonedefaults to an empty string, so every read ofSettings.Default.TimeZoneInfothrew and swallowed aTimeZoneNotFoundException. The main window caches its zone, but the format editor added in #140 refreshes its preview on a 1-secondDispatcherTimerand reads the property each time — producingException thrown: 'System.TimeZoneNotFoundException' in mscorlib.dllin the debug output on every tick.