Skip to content

(BugFix) Handle item mid-transition gracefully in vision mode. Report issues if this causes vision mode to not load too often #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjshrader merged 4 commits into from
Jun 23, 2026
Merged

(BugFix) Handle item mid-transition gracefully in vision mode. Report issues if this causes vision mode to not load too often #787

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fff1c02
fix(vision_mode): handle item mid-transition gracefully
chrisoro Jun 16, 2026
15562d6
review
chrisoro Jun 17, 2026
4ea4a1e
Merge branch 'main' into fix-697
cjshrader Jun 23, 2026
93dcf08
Merge branch 'main' into fix-697
cjshrader Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/scripts/vision_mode_with_highlighting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,11 @@ def evaluate_item_and_queue_draw(self, item_descr: Item):
item_descr_with_loc = item_descr
else:
item_descr_with_loc = src.item.descr.read_descr_tts.read_descr_mixed(cropped_descr)
if item_descr_with_loc is None:
Comment thread
chrisoro marked this conversation as resolved.
Outdated
# Item was likely mid-transition and could not be read; skip without drawing
LOGGER.debug("Item could not be read (likely in transition); skipping draw")
self.request_clear()
return
res = Filter().should_keep(item_descr_with_loc)
match = res.keep

Expand All @@ -395,7 +400,9 @@ def evaluate_item_and_queue_draw(self, item_descr: Item):
except CancellationRequestedError:
pass
except Exception:
LOGGER.exception("Error in vision mode. Please create a bug report")
LOGGER.exception(
"Error in vision mode. If an item was mid-transition this is harmless; if it repeats, please create a bug report."
)
finally:
self.evaluate_item_thread = None

Expand Down
2 changes: 0 additions & 2 deletions tests/gui/importer/test_mobalytics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@
"https://mobalytics.gg/diablo-4/profile/screamheart/builds/15x-thrash-out-of-date",
# This one has an item type for the weapon
"https://mobalytics.gg/diablo-4/builds/druid-zaior-pulverize-druid",
# This has two rogue offhand weapons
"https://mobalytics.gg/diablo-4/builds/rogue-efficientrogue-dance-of-knives?ws-ngf5-1=activeVariantId%2Ca2977139-f3e2-4b13-aa64-82ba69972528",
]


Expand Down
Loading