Add rarity filter for affixes, sigils, and tributes#786
Open
chrisoro wants to merge 2 commits into
Open
Conversation
Every rarity-bearing object can now be gated on item rarity. Lets crafters keep a rare/magic base while ignoring the equivalent legendary that matches the same affixes. - Affixes: ItemFilterModel gains a `rarity` constraint, an item-level gate alongside itemType/minPower. Keep paths (legendary aspect, GlobalUniques, mythic-always-keep) are unchanged. - Sigils: SigilFilterModel gains a global `rarity` gate. Rarity is derived from sigil affixes via the sigils.json rarities map; unresolved rarity is fail-closed and logged at debug. - Tributes: canonical key is now singular `rarity`; `rarities` stays as a back-compat validation alias. One shared rarity normalizer. - Fix sigil editor so a top-level affix can be blacklisted globally without picking a dungeon; affix-kind rows hide the condition UI. Refs ADR-0001, ADR-0002, ADR-0003. Closes #502. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
cjshrader
reviewed
Jun 17, 2026
cjshrader
requested changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #771 #502