Skip to content

Fix/script cross platform compat #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julian-CStack merged 3 commits into from
May 28, 2026
Merged

Fix/script cross platform compat #1388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d514c3
Parameterize build_all.sh, remove per-app build script variants
danrmiller May 27, 2026
0d3742d
use portable sed -i.bak in configure and version scripts from @parasew
danrmiller May 27, 2026
5111cec
Merge branch 'staging' into fix/script-cross-platform-compat
julian-CStack May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions scripts/app_config/configure_stack_duo.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,11 @@ NEW_PUBSPEC_NAME="stackduo"
PUBSPEC_FILE="${APP_PROJECT_ROOT_DIR}/pubspec.yaml"

# String replacements.
if [[ "$(uname)" == 'Darwin' ]]; then
# macos specific sed
sed -i '' "s/name: PLACEHOLDER/name: ${NEW_PUBSPEC_NAME}/g" "${PUBSPEC_FILE}"
sed -i '' "s/description: PLACEHOLDER/description: ${NEW_NAME}/g" "${PUBSPEC_FILE}"
else
sed -i "s/name: PLACEHOLDER/name: ${NEW_PUBSPEC_NAME}/g" "${PUBSPEC_FILE}"
sed -i "s/description: PLACEHOLDER/description: ${NEW_NAME}/g" "${PUBSPEC_FILE}"
fi
sed -i.bak \
-e "s/name: PLACEHOLDER/name: ${NEW_PUBSPEC_NAME}/g" \
-e "s/description: PLACEHOLDER/description: ${NEW_NAME}/g" \
"${PUBSPEC_FILE}"
rm -f "${PUBSPEC_FILE}.bak"

dart "${APP_PROJECT_ROOT_DIR}/tool/process_pubspec_deps.dart" \
"${PUBSPEC_FILE}" \
Expand Down
13 changes: 5 additions & 8 deletions scripts/app_config/configure_stack_wallet.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,11 @@ NEW_PUBSPEC_NAME="stackwallet"
PUBSPEC_FILE="${APP_PROJECT_ROOT_DIR}/pubspec.yaml"

# String replacements.
if [[ "$(uname)" == 'Darwin' ]]; then
# macos specific sed
sed -i '' "s/name: PLACEHOLDER/name: ${NEW_PUBSPEC_NAME}/g" "${PUBSPEC_FILE}"
sed -i '' "s/description: PLACEHOLDER/description: ${NEW_NAME}/g" "${PUBSPEC_FILE}"
else
sed -i "s/name: PLACEHOLDER/name: ${NEW_PUBSPEC_NAME}/g" "${PUBSPEC_FILE}"
sed -i "s/description: PLACEHOLDER/description: ${NEW_NAME}/g" "${PUBSPEC_FILE}"
fi
sed -i.bak \
-e "s/name: PLACEHOLDER/name: ${NEW_PUBSPEC_NAME}/g" \
-e "s/description: PLACEHOLDER/description: ${NEW_NAME}/g" \
"${PUBSPEC_FILE}"
rm -f "${PUBSPEC_FILE}.bak"

dart "${APP_PROJECT_ROOT_DIR}/tool/process_pubspec_deps.dart" \
"${PUBSPEC_FILE}" \
Expand Down
19 changes: 14 additions & 5 deletions scripts/app_config/platforms/macos/platform_config.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,17 @@ for (( i=0; i<=2; i++ )); do
done

# Configure macOS for Duo.
sed -i '' "s/${APP_ID_PLACEHOLDER_CAMEL}/${NEW_APP_ID_CAMEL}/g" "${APP_PROJECT_ROOT_DIR}/${MAC_TF_0}"
sed -i '' "s/${APP_NAME_PLACEHOLDER}/${NEW_NAME}/g" "${APP_PROJECT_ROOT_DIR}/${MAC_TF_0}"
sed -i '' "s/${APP_NAME_PLACEHOLDER}/${NEW_NAME}/g" "${APP_PROJECT_ROOT_DIR}/${MAC_TF_1}"
sed -i '' "s/${APP_NAME_PLACEHOLDER}/${NEW_NAME}/g" "${APP_PROJECT_ROOT_DIR}/${MAC_TF_2}"
sed -i '' "s/${APP_ID_PLACEHOLDER_SNAKE}/${NEW_APP_ID_SNAKE}/g" "${APP_PROJECT_ROOT_DIR}/${MAC_TF_2}"
sed -i.bak \
-e "s/${APP_ID_PLACEHOLDER_CAMEL}/${NEW_APP_ID_CAMEL}/g" \
-e "s/${APP_NAME_PLACEHOLDER}/${NEW_NAME}/g" \
"${APP_PROJECT_ROOT_DIR}/${MAC_TF_0}"
rm -f "${APP_PROJECT_ROOT_DIR}/${MAC_TF_0}.bak"

sed -i.bak "s/${APP_NAME_PLACEHOLDER}/${NEW_NAME}/g" "${APP_PROJECT_ROOT_DIR}/${MAC_TF_1}"
rm -f "${APP_PROJECT_ROOT_DIR}/${MAC_TF_1}.bak"

sed -i.bak \
-e "s/${APP_NAME_PLACEHOLDER}/${NEW_NAME}/g" \
-e "s/${APP_ID_PLACEHOLDER_SNAKE}/${NEW_APP_ID_SNAKE}/g" \
"${APP_PROJECT_ROOT_DIR}/${MAC_TF_2}"
rm -f "${APP_PROJECT_ROOT_DIR}/${MAC_TF_2}.bak"
15 changes: 6 additions & 9 deletions scripts/app_config/shared/update_version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

set -x -e

Expand Down Expand Up @@ -34,13 +34,10 @@ if [ ! -f "$PUBSPEC_FILE" ]; then
exit 1
fi

if [[ "$(uname)" == 'Darwin' ]]; then
# macos specific sed
sed -i '' "s/PLACEHOLDER_V/$VERSION/g" "${PUBSPEC_FILE}"
sed -i '' "s/PLACEHOLDER_B/$BUILD_NUMBER/g" "${PUBSPEC_FILE}"
else
sed -i "s/PLACEHOLDER_V/$VERSION/g" "${PUBSPEC_FILE}"
sed -i "s/PLACEHOLDER_B/$BUILD_NUMBER/g" "${PUBSPEC_FILE}"
fi
sed -i.bak \
-e "s/PLACEHOLDER_V/$VERSION/g" \
-e "s/PLACEHOLDER_B/$BUILD_NUMBER/g" \
"${PUBSPEC_FILE}"
rm -f "${PUBSPEC_FILE}.bak"

echo "Updated $PUBSPEC_FILE with version: $VERSION and build number: $BUILD_NUMBER"
Loading