Fix estimate_relative_pose bundle_opt argument for poselib>=2.0.4 (#154) - #175
Open
kunjikakgp wants to merge 1 commit into
Open
Fix estimate_relative_pose bundle_opt argument for poselib>=2.0.4 (#154)#175kunjikakgp wants to merge 1 commit into
kunjikakgp wants to merge 1 commit into
Conversation
…g#154) Fixes cvg#154. poselib.estimate_relative_pose() was called with only 5 positional args; on poselib builds where bundle_opt is not resolved as optional, this raises a TypeError during overload resolution. Passing an explicit empty bundle_opt dict fixes it. Verified against poselib 2.0.4 and 2.0.5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #154. poselib.estimate_relative_pose() was called with only 5 positional args; on poselib builds where bundle_opt is not resolved as optional, this raises a TypeError during overload resolution. Passing an explicit empty bundle_opt dict fixes it. Verified against poselib 2.0.4 and 2.0.5.
Testing: reproduced the failing call signature directly against the compiled poselib extension using the same argument types as this code path (numpy float64 [m,2] point arrays, dict camera params). Confirmed the 6-arg call (with explicit bundle_opt={}) succeeds on both poselib==2.0.4 and poselib==2.0.5, and that
python -m py_compilepasses on the patched file.