Fix: Set accessToken cookie after Firebase authentication#184
Open
railway-app[bot] wants to merge 1 commit into
Open
Fix: Set accessToken cookie after Firebase authentication#184railway-app[bot] wants to merge 1 commit into
railway-app[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After a successful
signInWithRedirectlogin,handleRedirectResultinAuthContext.tsxretrieved the Firebase user but never extracted or stored the ID token as a cookie. The backend middleware (server/src/middleware.ts) checksreq.cookies.accessTokenon every authenticated request, so all post-login API calls immediately failed with "@verifytoken invalid access token".Solution
Added
result.user.getIdToken()immediately after confirming a valid redirect result, then calledsetCookie({ key: cookieKeys.ACCESS_TOKEN, value: idToken })to persist the token before any backend requests are made. Also importedcookieKeysandsetCookiefrom../utils/auth/cookie, matching the same pattern already used inrefreshToken()infirebase.ts.Changes
client/src/contexts/AuthContext.tsxGenerated by Railway
Summary by cubic
Store the ID token as an
accessTokencookie right after Firebase redirect sign-in so authenticated API calls work. Fixes post-login requests failing with "@verifytoken invalid access token".Written for commit 81b6c36. Summary will update on new commits.