build(deps): bump bytes from 1.7.2 to 1.11.1#5
clippy
98 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 98 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.93.0 (254b59607 2026-01-19)
- cargo 1.93.0 (083ac5135 2025-12-15)
- clippy 0.1.93 (254b59607d 2026-01-19)
Annotations
Check warning on line 223 in rp/src/exchange.rs
github-actions / clippy
this expression borrows a value the compiler would automatically borrow
warning: this expression borrows a value the compiler would automatically borrow
--> rp/src/exchange.rs:223:34
|
223 | let final_cleanup_handlers = (&cleanup_handlers).clone();
| ^^^^^^^^^^^^^^^^^^^ help: change this to: `cleanup_handlers`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Check warning on line 171 in rp/src/exchange.rs
github-actions / clippy
very complex type used. Consider factoring parts into `type` definitions
warning: very complex type used. Consider factoring parts into `type` definitions
--> rp/src/exchange.rs:171:5
|
171 | Arc<::futures::lock::Mutex<Vec<Pin<Box<dyn Future<Output = Result<(), Error>> + Send>>>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
Check warning on line 371 in rosenpass/src/msgs.rs
github-actions / clippy
item uses `packed` representation without ABI-qualification
warning: item uses `packed` representation without ABI-qualification
--> rosenpass/src/msgs.rs:368:1
|
366 | #[repr(packed)]
| ------ `packed` representation set here
367 | #[derive(AsBytes, FromBytes, FromZeroes)]
368 | / pub struct CookieReply {
369 | | pub inner: CookieReplyInner,
370 | | pub padding: [u8; size_of::<Envelope<InitHello>>() - size_of::<CookieReplyInner>()],
371 | | }
| |_^
|
= warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI
= help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#repr_packed_without_abi
Check warning on line 350 in rosenpass/src/msgs.rs
github-actions / clippy
item uses `packed` representation without ABI-qualification
warning: item uses `packed` representation without ABI-qualification
--> rosenpass/src/msgs.rs:341:1
|
339 | #[repr(packed)]
| ------ `packed` representation set here
340 | #[derive(AsBytes, FromBytes, FromZeroes)]
341 | / pub struct CookieReplyInner {
342 | | /// [MsgType] of this message
343 | | pub msg_type: u8,
344 | | /// Reserved for future use
... |
349 | | pub cookie_encrypted: [u8; xaead::NONCE_LEN + COOKIE_SIZE + xaead::TAG_LEN],
350 | | }
| |_^
|
= warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI
= help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#repr_packed_without_abi
Check warning on line 323 in rosenpass/src/msgs.rs
github-actions / clippy
item uses `packed` representation without ABI-qualification
warning: item uses `packed` representation without ABI-qualification
--> rosenpass/src/msgs.rs:316:1
|
314 | #[repr(packed)]
| ------ `packed` representation set here
315 | #[derive(AsBytes, FromBytes, FromZeroes)]
316 | / pub struct Biscuit {
317 | | /// H(spki) – Ident ifies the initiator
318 | | pub pidi: [u8; KEY_LEN],
319 | | /// The biscuit number (replay protection)
... |
322 | | pub ck: [u8; KEY_LEN],
323 | | }
| |_^
|
= warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI
= help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#repr_packed_without_abi
Check warning on line 296 in rosenpass/src/msgs.rs
github-actions / clippy
item uses `packed` representation without ABI-qualification
warning: item uses `packed` representation without ABI-qualification
--> rosenpass/src/msgs.rs:289:1
|
287 | #[repr(packed)]
| ------ `packed` representation set here
288 | #[derive(AsBytes, FromBytes, FromZeroes, Clone, Copy)]
289 | / pub struct EmptyData {
290 | | /// Copied from RespHello
291 | | pub sid: [u8; 4],
292 | | /// Nonce
... |
295 | | pub auth: [u8; aead::TAG_LEN],
296 | | }
| |_^
|
= warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI
= help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#repr_packed_without_abi
Check warning on line 240 in rosenpass/src/msgs.rs
github-actions / clippy
item uses `packed` representation without ABI-qualification
warning: item uses `packed` representation without ABI-qualification
--> rosenpass/src/msgs.rs:231:1
|
229 | #[repr(packed)]
| ------ `packed` representation set here
230 | #[derive(AsBytes, FromBytes, FromZeroes, Debug)]
231 | / pub struct InitConf {
232 | | /// Copied from InitHello
233 | | pub sidi: [u8; 4],
234 | | /// Copied from RespHello
... |
239 | | pub auth: [u8; aead::TAG_LEN],
240 | | }
| |_^
|
= warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI
= help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#repr_packed_without_abi
Check warning on line 193 in rosenpass/src/msgs.rs
github-actions / clippy
item uses `packed` representation without ABI-qualification
warning: item uses `packed` representation without ABI-qualification
--> rosenpass/src/msgs.rs:180:1
|
178 | #[repr(packed)]
| ------ `packed` representation set here
179 | #[derive(AsBytes, FromBytes, FromZeroes)]
180 | / pub struct RespHello {
181 | | /// Randomly generated connection id
182 | | pub sidr: [u8; 4],
183 | | /// Copied from InitHello
... |
192 | | pub biscuit: [u8; BISCUIT_CT_LEN],
193 | | }
| |_^
|
= warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI
= help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#repr_packed_without_abi
Check warning on line 142 in rosenpass/src/msgs.rs
github-actions / clippy
item uses `packed` representation without ABI-qualification
warning: item uses `packed` representation without ABI-qualification
--> rosenpass/src/msgs.rs:131:1
|
129 | #[repr(packed)]
| ------ `packed` representation set here
130 | #[derive(AsBytes, FromBytes, FromZeroes)]
131 | / pub struct InitHello {
132 | | /// Randomly generated connection id
133 | | pub sidi: [u8; 4],
134 | | /// Kyber 512 Ephemeral Public Key
... |
141 | | pub auth: [u8; aead::TAG_LEN],
142 | | }
| |_^
|
= warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI
= help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#repr_packed_without_abi
Check warning on line 93 in rosenpass/src/msgs.rs
github-actions / clippy
item uses `packed` representation without ABI-qualification
warning: item uses `packed` representation without ABI-qualification
--> rosenpass/src/msgs.rs:81:1
|
79 | #[repr(packed)]
| ------ `packed` representation set here
80 | #[derive(AsBytes, FromBytes, FromZeroes, Clone)]
81 | / pub struct Envelope<M: AsBytes + FromBytes> {
82 | | /// [MsgType] of this message
83 | | pub msg_type: u8,
84 | | /// Reserved for future use
... |
92 | | pub cookie: MsgEnvelopeCookie,
93 | | }
| |_^
|
= warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI
= help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#repr_packed_without_abi
Check warning on line 12 in rosenpass/src/msgs.rs
github-actions / clippy
importing legacy numeric constants
warning: importing legacy numeric constants
--> rosenpass/src/msgs.rs:12:5
|
12 | use std::u8;
| ^^^^^^^
|
= help: remove this import
= note: then `u8::<CONST>` will resolve to the respective associated constant
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#legacy_numeric_constants
= note: `#[warn(clippy::legacy_numeric_constants)]` on by default
Check warning on line 176 in rosenpass/src/api/boilerplate/server.rs
github-actions / clippy
doc list item overindented
warning: doc list item overindented
--> rosenpass/src/api/boilerplate/server.rs:176:9
|
176 | /// with unix socket file descriptor passing)
| ^^^ help: try using ` ` (2 spaces)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_overindented_list_items
= note: `#[warn(clippy::doc_overindented_list_items)]` on by default
Check warning on line 365 in rosenpass/src/api/boilerplate/payload.rs
github-actions / clippy
item uses `packed` representation without ABI-qualification
warning: item uses `packed` representation without ABI-qualification
--> rosenpass/src/api/boilerplate/payload.rs:363:1
|
361 | #[repr(packed)]
| ------ `packed` representation set here
362 | #[derive(Debug, Copy, Clone, Hash, AsBytes, FromBytes, FromZeroes, PartialEq, Eq)]
363 | / pub struct AddPskBrokerResponsePayload {
364 | | pub status: u128,
365 | | }
| |_^
|
= warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI
= help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#repr_packed_without_abi
Check warning on line 308 in rosenpass/src/api/boilerplate/payload.rs
github-actions / clippy
item uses `packed` representation without ABI-qualification
warning: item uses `packed` representation without ABI-qualification
--> rosenpass/src/api/boilerplate/payload.rs:308:1
|
306 | #[repr(packed)]
| ------ `packed` representation set here
307 | #[derive(Debug, Copy, Clone, Hash, AsBytes, FromBytes, FromZeroes, PartialEq, Eq)]
308 | pub struct AddPskBrokerRequestPayload {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI
= help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#repr_packed_without_abi
Check warning on line 270 in rosenpass/src/api/boilerplate/payload.rs
github-actions / clippy
item uses `packed` representation without ABI-qualification
warning: item uses `packed` representation without ABI-qualification
--> rosenpass/src/api/boilerplate/payload.rs:268:1
|
266 | #[repr(packed)]
| ------ `packed` representation set here
267 | #[derive(Debug, Copy, Clone, Hash, AsBytes, FromBytes, FromZeroes, PartialEq, Eq)]
268 | / pub struct AddListenSocketResponsePayload {
269 | | pub status: u128,
270 | | }
| |_^
|
= warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI
= help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#repr_packed_without_abi
Check warning on line 214 in rosenpass/src/api/boilerplate/payload.rs
github-actions / clippy
item uses `packed` representation without ABI-qualification
warning: item uses `packed` representation without ABI-qualification
--> rosenpass/src/api/boilerplate/payload.rs:214:1
|
212 | #[repr(packed)]
| ------ `packed` representation set here
213 | #[derive(Debug, Copy, Clone, Hash, AsBytes, FromBytes, FromZeroes, PartialEq, Eq)]
214 | pub struct AddListenSocketRequestPayload {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI
= help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#repr_packed_without_abi
Check warning on line 176 in rosenpass/src/api/boilerplate/payload.rs
github-actions / clippy
item uses `packed` representation without ABI-qualification
warning: item uses `packed` representation without ABI-qualification
--> rosenpass/src/api/boilerplate/payload.rs:173:1
|
171 | #[repr(packed)]
| ------ `packed` representation set here
172 | #[derive(Debug, Copy, Clone, Hash, AsBytes, FromBytes, FromZeroes, PartialEq, Eq)]
173 | / pub struct SupplyKeypairResponsePayload {
174 | | #[allow(missing_docs)]
175 | | pub status: u128,
176 | | }
| |_^
|
= warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI
= help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#repr_packed_without_abi
Check warning on line 113 in rosenpass/src/api/boilerplate/payload.rs
github-actions / clippy
item uses `packed` representation without ABI-qualification
warning: item uses `packed` representation without ABI-qualification
--> rosenpass/src/api/boilerplate/payload.rs:113:1
|
111 | #[repr(packed)]
| ------ `packed` representation set here
112 | #[derive(Debug, Copy, Clone, Hash, AsBytes, FromBytes, FromZeroes, PartialEq, Eq)]
113 | pub struct SupplyKeypairRequestPayload {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI
= help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#repr_packed_without_abi
Check warning on line 75 in rosenpass/src/api/boilerplate/payload.rs
github-actions / clippy
item uses `packed` representation without ABI-qualification
warning: item uses `packed` representation without ABI-qualification
--> rosenpass/src/api/boilerplate/payload.rs:72:1
|
70 | #[repr(packed)]
| ------ `packed` representation set here
71 | #[derive(Debug, Copy, Clone, Hash, AsBytes, FromBytes, FromZeroes, PartialEq, Eq)]
72 | / pub struct PingResponsePayload {
73 | | /// Randomly generated connection id
74 | | pub echo: [u8; 256],
75 | | }
| |_^
|
= warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI
= help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#repr_packed_without_abi
Check warning on line 34 in rosenpass/src/api/boilerplate/payload.rs
github-actions / clippy
item uses `packed` representation without ABI-qualification
warning: item uses `packed` representation without ABI-qualification
--> rosenpass/src/api/boilerplate/payload.rs:31:1
|
29 | #[repr(packed)]
| ------ `packed` representation set here
30 | #[derive(Debug, Copy, Clone, Hash, AsBytes, FromBytes, FromZeroes, PartialEq, Eq)]
31 | / pub struct PingRequestPayload {
32 | | /// Randomly generated connection id
33 | | pub echo: [u8; 256],
34 | | }
| |_^
|
= warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI
= help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#repr_packed_without_abi
Check warning on line 21 in rosenpass/src/api/boilerplate/payload.rs
github-actions / clippy
item uses `packed` representation without ABI-qualification
warning: item uses `packed` representation without ABI-qualification
--> rosenpass/src/api/boilerplate/payload.rs:16:1
|
14 | #[repr(packed)]
| ------ `packed` representation set here
15 | #[derive(Debug, Copy, Clone, Hash, AsBytes, FromBytes, FromZeroes, PartialEq, Eq)]
16 | / pub struct Envelope<M: AsBytes + FromBytes> {
17 | | /// Which message this is
18 | | pub msg_type: RawMsgType,
19 | | /// The actual Paylod
20 | | pub payload: M,
21 | | }
| |_^
|
= warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI
= help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#repr_packed_without_abi
= note: `#[warn(clippy::repr_packed_without_abi)]` on by default
Check warning on line 149 in rosenpass/src/cli.rs
github-actions / clippy
empty line after doc comment
warning: empty line after doc comment
--> rosenpass/src/cli.rs:148:5
|
148 | / /// Returns `None` if the `experiment_api` feature is disabled.
149 | |
| |_^
150 | #[cfg(feature = "experiment_api")]
151 | pub fn get_broker_interface(&self) -> Option<BrokerInterface> {
| --------------------------- the comment documents this function
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#empty_line_after_doc_comments
= note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
= help: if the empty line is unintentional, remove it
Check warning on line 36 in ciphers/src/hash_domain.rs
github-actions / clippy
empty line after doc comment
warning: empty line after doc comment
--> ciphers/src/hash_domain.rs:35:1
|
35 | / ///
36 | |
| |_^
...
42 | pub struct HashDomain([u8; KEY_LEN]);
| --------------------- the comment documents this struct
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#empty_line_after_doc_comments
= note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
= help: if the empty line is unintentional, remove it
help: if the doc comment should not document struct `HashDomain` then comment it out
|
9 ~ // ///
10 ~ // ///```rust
11 ~ // /// # use rosenpass_ciphers::hash_domain::{HashDomain, HashDomainNamespace, SecretHashDomain, SecretHashDomainNamespace};
12 ~ // /// use rosenpass_secret_memory::Secret;
13 ~ // /// # rosenpass_secret_memory::secret_policy_use_only_malloc_secrets();
14 ~ // ///
15 ~ // /// const PROTOCOL_IDENTIFIER: &str = "MY_PROTOCOL:IDENTIFIER";
16 ~ // /// // create use once hash domain for the protocol identifier
17 ~ // /// let mut hash_domain = HashDomain::zero();
18 ~ // /// hash_domain = hash_domain.mix(PROTOCOL_IDENTIFIER.as_bytes())?;
19 ~ // /// // upgrade to reusable hash domain
20 ~ // /// let hash_domain_namespace: HashDomainNamespace = hash_domain.dup();
21 ~ // /// // derive new key
22 ~ // /// let key_identifier = "my_key_identifier";
23 ~ // /// let key = hash_domain_namespace.mix(key_identifier.as_bytes())?.into_value();
24 ~ // /// // derive a new key based on a secret
25 ~ // /// const MY_SECRET_LEN: usize = 21;
26 ~ // /// let my_secret_bytes = "my super duper secret".as_bytes();
27 ~ // /// let my_secret: Secret<21> = Secret::from_slice("my super duper secret".as_bytes());
28 ~ // /// let secret_hash_domain: SecretHashDomain = hash_domain_namespace.mix_secret(my_secret)?;
29 ~ // /// // derive a new key based on the secret key
30 ~ // /// let new_key_identifier = "my_new_key_identifier".as_bytes();
31 ~ // /// let new_key = secret_hash_domain.mix(new_key_identifier)?.into_secret();
32 ~ // ///
33 ~ // /// # Ok::<(), anyhow::Error>(())
34 ~ // ///```
35 ~ // ///
|
Check warning on line 29 in constant-time/src/compare.rs
github-actions / clippy
unsafe function's docs are missing a `# Safety` section
warning: unsafe function's docs are missing a `# Safety` section
--> constant-time/src/compare.rs:29:1
|
29 | pub unsafe fn memcmp_le(b1: *const u8, b2: *const u8, len: usize) -> i32 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#missing_safety_doc
= note: `#[warn(clippy::missing_safety_doc)]` on by default
Check warning on line 91 in wireguard-broker/src/api/msgs.rs
github-actions / clippy
item uses `packed` representation without ABI-qualification
warning: item uses `packed` representation without ABI-qualification
--> wireguard-broker/src/api/msgs.rs:89:1
|
87 | #[repr(packed)]
| ------ `packed` representation set here
88 | #[derive(AsBytes, FromBytes, FromZeroes)]
89 | / pub struct SetPskResponse {
90 | | pub return_code: u8,
91 | | }
| |_^
|
= warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI
= help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#repr_packed_without_abi