fix(hax-lib): Fix refinement macro in presence of generics.#2047
Draft
maximebuyse wants to merge 1 commit into
Draft
fix(hax-lib): Fix refinement macro in presence of generics.#2047maximebuyse wants to merge 1 commit into
maximebuyse wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #899 . Claude generated.
Root cause
#[hax_lib::attributes]on a struct generates, for each#[refine(...)]-annotated field, a hiddenrefinementfunction whoseparameters are the struct's fields:
This function was generated without the struct's generics. So when a field
type (or the refinement formula) mentions a const generic such as
LEN, thatparameter is out of scope.
Under hax extraction (which actually compiles this
#[cfg(hax_compilation)]item) this produced:
and, in the engine, the field list and the refinement function's parameter
list then went out of sync, surfacing as the reported error:
The fix
In
hax-lib/macros/src/implementation.rs, the struct's generics are nowpropagated to the generated
refinementfunction. Generic defaults arestripped (they are not allowed on function generics) and the where-clause is
carried along:
Unused generics are harmless on functions, so this is safe for any struct
shape (type params, const params, lifetimes, and combinations).
After the fix, the reproducer extracts to a correct refined F* type: