do not make decision required to do RDNS enrichment#1825
Merged
Conversation
buixor
commented
Jun 15, 2026
buixor
commented
Contributor
- fixed a bug where RDNS based postoverflow whitelists wouldn't work because RDNS enrichment only happens if there is a decision in the alert.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes RDNS-based postoverflow whitelist behavior by ensuring the crowdsecurity/rdns postoverflow enrichment runs for IP-scoped overflow alerts even when no remediation/decision is present on the alert.
Changes:
- Relaxed the
crowdsecurity/rdnspostoverflow filter to run for all overflow alerts whose scope isIp(removed theRemediation == truecondition).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.