docs: argocd healthcheck - mark packages Degraded when Installed=False#1091
Open
ytsarev wants to merge 1 commit into
Open
docs: argocd healthcheck - mark packages Degraded when Installed=False#1091ytsarev wants to merge 1 commit into
ytsarev wants to merge 1 commit into
Conversation
Crossplane packages (Function, Provider, Configuration) expose two status conditions: `Installed` (the package spec resolved and was unpacked) and `Healthy` (the active PackageRevision is healthy). When `spec.package` is changed to a tag that cannot be resolved or unpacked, the new generation reports `Installed=False` (reason: `UnpackingPackage`, `InvalidPackageRevisionSpec`, ...), but the previously active revision continues to report `Healthy=True / HealthyPackageRevision` with a stale `observedGeneration`. The Lua healthcheck only matched positive condition types and therefore stamped the package as Healthy in ArgoCD even though the GitOps change had failed to roll out. Add an explicit branch that early-returns Degraded when an `Installed` condition is False, mirroring the existing handling for `Synced` and `LastAsyncOperation`. The new branch is a no-op for non-package kinds and for the steady-state `Installed=True / ActivePackageRevision` case. Signed-off-by: Yury Tsarev <yury@upbound.io>
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
@ytsarev can you check for vale Issues ? |
Member
Author
|
@haarchri none of them are related to the change. Do you want me to fix it inline in this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crossplane packages (Function, Provider, Configuration) expose two status conditions:
Installed(the package spec resolved and was unpacked) andHealthy(the active PackageRevision is healthy). Whenspec.packageis changed to a tag that cannot be resolved or unpacked, the new generation reportsInstalled=False(reason:UnpackingPackage,InvalidPackageRevisionSpec, ...), but the previously active revision continues to reportHealthy=True / HealthyPackageRevisionwith a staleobservedGeneration. The Lua healthcheck only matched positive condition types and therefore stamped the package as Healthy in ArgoCD even though the GitOps change had failed to roll out.Add an explicit branch that early-returns Degraded when an
Installedcondition is False, mirroring the existing handling forSyncedandLastAsyncOperation. The new branch is a no-op for non-package kinds and for the steady-stateInstalled=True / ActivePackageRevisioncase.Before - the error is unclear and hidden by Progressing:
After - the error is surface: