Skip to content

fix(crons): probe stat -c before stat -f in writeback.sh #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdbridgeman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(crons): probe stat -c before stat -f in writeback.sh #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion skills/crons/writeback.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,14 @@ _refresh_reconciling_if_fresh() {
local marker="$MEMORY_DIR/.reconciling"
[[ -f "$marker" ]] || return 0
local marker_mtime now_s age
marker_mtime=$(stat -f %m "$marker" 2>/dev/null || stat -c %Y "$marker" 2>/dev/null || echo 0)
# GNU-first, value-checked probe: on GNU coreutils `stat -f %m` means
# "filesystem status" and prints a multi-line block to stdout while exiting
# non-zero, so the old BSD-first order let the `||` fallback APPEND the real
# epoch — leaving marker_mtime as a blob containing the word "File", which
# then trips `set -u` in the arithmetic below. `stat -c %Y` succeeds on GNU
# and fails cleanly (no stdout) on BSD/macOS, where `stat -f %m` takes over.
marker_mtime=$(stat -c %Y "$marker" 2>/dev/null || stat -f %m "$marker" 2>/dev/null || echo 0)
[[ "$marker_mtime" =~ ^[0-9]+$ ]] || marker_mtime=0
now_s=$(date +%s)
age=$((now_s - marker_mtime))
if [[ $age -ge 0 && $age -lt 600 ]]; then
Expand Down