I/O: Apache Iceberg (implement suggestions by CodeRabbit)

Author: amotl

cratedb_toolkit/cluster/core.py

@@ -653,7 +653,12 @@ def save_table(
         if target_url_obj.scheme.startswith("iceberg") or target_url_obj.scheme.endswith("iceberg"):
             from cratedb_toolkit.io.iceberg import to_iceberg
 
-            to_iceberg(source_url, target.url)
+            if to_iceberg(source_url, target.url):
+                self._load_table_result = True
+            else:
+                logger.error("Data loading failed or incomplete")
+                self._load_table_result = False
+
         else:
             raise NotImplementedError(f"Exporting resource not implemented yet: {target_url_obj}")
 

cratedb_toolkit/io/iceberg.py

@@ -38,7 +38,7 @@ class IcebergAddress:
     catalog: str
     namespace: str
     table: str
-    batch_size: Optional[int] = None
+    batch_size: Optional[int] = DEFAULT_BATCH_SIZE
 
     def __post_init__(self):
         self.tmpdir = tempfile.TemporaryDirectory()

pyproject.toml

@@ -386,7 +386,7 @@ tasks.check = [
   "test",
 ]
 tasks.docs-autobuild = [
-  { cmd = "sphinx-autobuild --open-browser doc doc/_build" },
+  { cmd = "sphinx-autobuild --open-browser --watch cratedb_toolkit doc doc/_build" },
 ]
 tasks.docs-html = [
   { cmd = "sphinx-build -W --keep-going doc doc/_build" },