Skip to content

Skip loadBalancerSourceRanges patch for non-LoadBalancer services #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tomach wants to merge 4 commits into from
Closed

Skip loadBalancerSourceRanges patch for non-LoadBalancer services #820

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fdcfc26
Skip loadBalancerSourceRanges patch for non-LoadBalancer services
tomach Mar 24, 2026
4c63e79
Check traefik resource on resume
tomach Mar 27, 2026
f9a6de5
fixup! Check traefik resource on resume
tomach Mar 27, 2026
629e829
Update clusterrole
tomach Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions crate/operator/handlers/handle_update_allowed_cidrs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,19 @@ async def update_service_allowed_cidrs(
if not service:
return

await core.patch_namespaced_service(
name=f"crate-{name}",
namespace=namespace,
body={"spec": {"loadBalancerSourceRanges": change.new}},
)
# Only patch loadBalancerSourceRanges if the service is of type LoadBalancer.
# For ClusterIP this field is forbidden and will cause a 422.
if service.spec.type == "LoadBalancer":
await core.patch_namespaced_service(
name=f"crate-{name}",
namespace=namespace,
body={"spec": {"loadBalancerSourceRanges": change.new}},
)
else:
logger.info(
f"Skipping loadBalancerSourceRanges patch: service 'crate-{name}' "
f"is of type '{service.spec.type}', not 'LoadBalancer'."
)

ingress = await read_grand_central_ingress(namespace=namespace, name=name)

Expand Down
Loading