Merged
Conversation
rsansores
approved these changes
Jul 28, 2025
rsansores
left a comment
rsansores
left a comment
There was a problem hiding this comment.
Looks correct, should we add Linux support to all these?
Contributor
Author
|
I've created #5 to track your suggestion, thank you. Merging this PR rather than trying to cram that work into this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a basic GitHub workflow to run the tests.
These are fairly minor modifications, however they might as well be merged into main rather than leaving the branch untended.
I didn't discover why the original test stopped working and then started working again after I'd added several more tiny tests. Something to keep an eye on in case the tests fail in future.