Skip to content

fix: avoid panic when parsing the create index on timestamp with/without time zone #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bbckr wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: avoid panic when parsing the create index on timestamp with/without time zone #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07b2f3a
fix: Panic on timestamp with/without in WHERE clause
bbckr Feb 17, 2025
2dccdfc
also when where is not present
bbckr Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion drivers/postgres/idxscan/idxscan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func ParseCreateIndex(s string) IndexDef {
idxwith := strings.Index(utail, "WITH")
idxtbsp := strings.Index(utail, "TABLESPACE")
idxwhere := strings.Index(utail, "WHERE")
if idxwith >= 0 {
if idxwith >= 0 && (idxwith < idxwhere || idxwhere < 0) { // avoid matching timestamp with/without time zone in where clause
idxto := len(tail)
if idxwhere >= 0 {
idxto = idxwhere
Expand Down
104 changes: 89 additions & 15 deletions drivers/postgres/idxscan/idxscan_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,22 @@ import (
"testing"
)

const testingQ = ` CREATE UNiQUE
INDEX uk_candidate_recruiter_info_email ON public.candidate
USING btree
( sdih COLLATE "ru_RU" int4 ASC NULLS LAST,
asfg COLLATE "ru_RU" DESC,
ertny,
((recruiter_info ->>
'email'::text))
)

WITH a= b, c = d,e=f
TABLESPACE f
WHERE as;roug (hblkas) bfdvvkjhb (3li54f9q3er opfbg78 9)erg`

func TestParseCreateIndex(t *testing.T) {
ss := ParseCreateIndex(testingQ)
s := ` CREATE UNiQUE
INDEX uk_candidate_recruiter_info_email ON public.candidate
USING btree
( sdih COLLATE "ru_RU" int4 ASC NULLS LAST,
asfg COLLATE "ru_RU" DESC,
ertny,
((recruiter_info ->>
'email'::text))
)

WITH a= b, c = d,e=f
TABLESPACE f
WHERE as;roug (hblkas) bfdvvkjhb (3li54f9q3er opfbg78 9)erg`

ss := ParseCreateIndex(s)
eq := IndexDef{
Name: "uk_candidate_recruiter_info_email",
Table: "public.candidate",
Expand All @@ -32,6 +32,80 @@ func TestParseCreateIndex(t *testing.T) {
Tablespace: "f",
Where: "as;roug (hblkas) bfdvvkjhb (3li54f9q3er opfbg78 9)erg",
}

if !reflect.DeepEqual(ss, eq) {
t.Errorf("%#v", ss)
}
}

func TestParseCreateIndex_NoWithAndTimestampWithTimezone(t *testing.T) {
s := `CREATE UNIQUE INDEX \"IX_customer_external_id\"
ON public.customer
USING btree (external_id)
WHERE (created > '2020-09-27 20:00:00.000000'::timestamp with time zone)`

ss := ParseCreateIndex(s)
eq := IndexDef{
Name: "\\\"IX_customer_external_id\\\"",
Table: "public.customer",
Unique: true,
Concurrently: false,
UsingType: "btree",
ColDef: "(external_id)",
With: "",
Tablespace: "",
Where: "(created > '2020-09-27 20:00:00.000000'::timestamp with time zone)",
}

if !reflect.DeepEqual(ss, eq) {
t.Errorf("%#v", ss)
}
}

func TestParseCreateIndex_WithAndTimestampWithoutTimezone(t *testing.T) {
s := `CREATE UNIQUE INDEX \"IX_customer_external_id\"
ON public.customer
USING btree (external_id)
WITH a= b
WHERE (created > '2020-09-27 20:00:00.000000'::timestamp without time zone)`

ss := ParseCreateIndex(s)
eq := IndexDef{
Name: "\\\"IX_customer_external_id\\\"",
Table: "public.customer",
Unique: true,
Concurrently: false,
UsingType: "btree",
ColDef: "(external_id)",
With: "a= b",
Tablespace: "",
Where: "(created > '2020-09-27 20:00:00.000000'::timestamp without time zone)",
}

if !reflect.DeepEqual(ss, eq) {
t.Errorf("%#v", ss)
}
}

func TestParseCreateIndex_NoWhere(t *testing.T) {
s := `CREATE UNIQUE INDEX \"IX_customer_external_id\"
ON public.customer
USING btree (external_id)
WITH a= b`

ss := ParseCreateIndex(s)
eq := IndexDef{
Name: "\\\"IX_customer_external_id\\\"",
Table: "public.customer",
Unique: true,
Concurrently: false,
UsingType: "btree",
ColDef: "(external_id)",
With: "a= b",
Tablespace: "",
Where: "",
}

if !reflect.DeepEqual(ss, eq) {
t.Errorf("%#v", ss)
}
Expand Down