Skip to content

feat: add LTS-specific build tags for v3 and v4 CRS releases#416

Merged
fzipi merged 6 commits intocoreruleset:mainfrom
fzipi:chore/add-lts-specific
Mar 31, 2026
Merged

feat: add LTS-specific build tags for v3 and v4 CRS releases#416
fzipi merged 6 commits intocoreruleset:mainfrom
fzipi:chore/add-lts-specific

Conversation

@fzipi
Copy link
Copy Markdown
Member

@fzipi fzipi commented Mar 29, 2026

Summary

  • Introduces v3-lts-crs-version and v4-lts-crs-version variables (renaming the old previous-major-crs-version) to track LTS releases independently from the monthly major-crs-version updates
  • v3-lts-crs-version is set to 3.3.9, v4-lts-crs-version is set to 4.25.0
  • Adds a new ltag HCL function that generates stable <minor>-<variant>-lts and <patch>-<variant>-lts tags (no timestamp), applied only when the build target matches the designated LTS version
  • Documents the new LTS tag format in README.md

Test plan

  • Verify docker buildx bake --print shows the expected LTS tags (e.g. 4.25-nginx-lts, 4.25.0-apache-lts) on the major-crs-version targets
  • Verify LTS tags are not present on the v3-lts-crs-version (3.3.9) targets
  • Verify existing stable and rolling tags are unaffected

🤖 Generated with Claude Code

fzipi and others added 2 commits March 29, 2026 11:22
Introduce `v3-lts-crs-version` and `v4-lts-crs-version` variables
(renamed from `previous-major-crs-version`) and a new `ltag` function
that generates stable `<minor>-<variant>-lts` and `<patch>-<variant>-lts`
tags applied only to the designated LTS release, independent of the
monthly `major-crs-version` updates. Document the new LTS tag format
in README.md.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@fzipi fzipi requested a review from theseion March 29, 2026 14:26
@fzipi fzipi enabled auto-merge March 29, 2026 14:28
Comment thread docker-bake.hcl Outdated
Comment thread docker-bake.hcl Outdated
fzipi and others added 2 commits March 29, 2026 12:00
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ames

When lts and latest point to the same CRS version, using a map produces
duplicate target names. Switch to a list of {tag, version} objects so
the target name uses the semantic key (previous/lts/latest) instead of
the version string. Also update verifyimage.yml to derive the CRS major
version by checking whether the target ends with "-previous" rather than
parsing a version number from the name.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@fzipi fzipi requested a review from theseion March 29, 2026 17:56
Comment thread docker-bake.hcl Outdated
Comment thread docker-bake.hcl Outdated
fzipi and others added 2 commits March 30, 2026 11:38
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@fzipi fzipi force-pushed the chore/add-lts-specific branch from 2811fc1 to 9e1f397 Compare March 30, 2026 14:41
@fzipi fzipi merged commit 6d651ae into coreruleset:main Mar 31, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants