feat: add LTS-specific build tags for v3 and v4 CRS releases#416
Merged
fzipi merged 6 commits intocoreruleset:mainfrom Mar 31, 2026
Merged
feat: add LTS-specific build tags for v3 and v4 CRS releases#416fzipi merged 6 commits intocoreruleset:mainfrom
fzipi merged 6 commits intocoreruleset:mainfrom
Conversation
Introduce `v3-lts-crs-version` and `v4-lts-crs-version` variables (renamed from `previous-major-crs-version`) and a new `ltag` function that generates stable `<minor>-<variant>-lts` and `<patch>-<variant>-lts` tags applied only to the designated LTS release, independent of the monthly `major-crs-version` updates. Document the new LTS tag format in README.md. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
theseion
requested changes
Mar 29, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ames
When lts and latest point to the same CRS version, using a map produces
duplicate target names. Switch to a list of {tag, version} objects so
the target name uses the semantic key (previous/lts/latest) instead of
the version string. Also update verifyimage.yml to derive the CRS major
version by checking whether the target ends with "-previous" rather than
parsing a version number from the name.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
theseion
requested changes
Mar 29, 2026
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2811fc1 to
9e1f397
Compare
theseion
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v3-lts-crs-versionandv4-lts-crs-versionvariables (renaming the oldprevious-major-crs-version) to track LTS releases independently from the monthlymajor-crs-versionupdatesv3-lts-crs-versionis set to3.3.9,v4-lts-crs-versionis set to4.25.0ltagHCL function that generates stable<minor>-<variant>-ltsand<patch>-<variant>-ltstags (no timestamp), applied only when the build target matches the designated LTS versionREADME.mdTest plan
docker buildx bake --printshows the expected LTS tags (e.g.4.25-nginx-lts,4.25.0-apache-lts) on themajor-crs-versiontargetsv3-lts-crs-version(3.3.9) targets🤖 Generated with Claude Code