Skip to content

feat: improve HTTP/2 configuration#372

Merged
theseion merged 3 commits intocoreruleset:mainfrom
theseion:improve-http2-setup
Aug 31, 2025
Merged

feat: improve HTTP/2 configuration#372
theseion merged 3 commits intocoreruleset:mainfrom
theseion:improve-http2-setup

Conversation

@theseion
Copy link
Copy Markdown
Contributor

  • add explicit HTTP/2 configuration to nginx
  • add h2c to default protocols for httpd
  • add H2Direct directive and configuration option to httpd

- add explicit HTTP/2 configuration to nginx
- add `h2c` to default protocols for httpd
- add `H2Direct` directive and configuration option to httpd
@theseion theseion requested a review from fzipi August 28, 2025 05:22
airween
airween previously approved these changes Aug 28, 2025
@fzipi
Copy link
Copy Markdown
Member

fzipi commented Aug 28, 2025

Do we want to add a test here like calling curl --http2 --verbose "http://localhost" 2>&1 | grep 'using HTTP/2'?

fzipi
fzipi previously approved these changes Aug 28, 2025
@theseion theseion dismissed stale reviews from fzipi and airween via b3ad68f August 29, 2025 05:30
@theseion theseion force-pushed the improve-http2-setup branch 4 times, most recently from ad7e9fc to 8b9afdc Compare August 29, 2025 06:01
Comment thread .github/workflows/verifyimage.yml Outdated
@theseion theseion force-pushed the improve-http2-setup branch 17 times, most recently from 7366abb to 70ff331 Compare August 31, 2025 08:03
@theseion theseion requested a review from fzipi August 31, 2025 08:03
@theseion theseion requested a review from airween August 31, 2025 08:03
@theseion
Copy link
Copy Markdown
Contributor Author

Fixed verification tests and improved log output. Please review.

@airween
Copy link
Copy Markdown

airween commented Aug 31, 2025

Fixed verification tests and improved log output. Please review.

Something is still wrong with CI.

@theseion theseion force-pushed the improve-http2-setup branch from 70ff331 to f2cf71b Compare August 31, 2025 08:26
@theseion
Copy link
Copy Markdown
Contributor Author

Yeah, sorry, just broke something and am trying to fix it again :)

@theseion theseion force-pushed the improve-http2-setup branch 11 times, most recently from 82acc90 to 7c27ff6 Compare August 31, 2025 09:34
@theseion
Copy link
Copy Markdown
Contributor Author

ok, fixed now.

@theseion theseion force-pushed the improve-http2-setup branch from 7c27ff6 to c35024e Compare August 31, 2025 09:42
@theseion theseion force-pushed the improve-http2-setup branch from c35024e to 4e3a488 Compare August 31, 2025 09:48
fzipi
fzipi previously approved these changes Aug 31, 2025
Comment thread .github/workflows/verifyimage.yml Outdated
Co-authored-by: Felipe Zipitría <3012076+fzipi@users.noreply.github.com>
Copy link
Copy Markdown

@airween airween left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theseion theseion merged commit 12bc7e2 into coreruleset:main Aug 31, 2025
5 checks passed
@theseion theseion deleted the improve-http2-setup branch September 1, 2025 07:43
@theseion theseion added the enhancement New feature or request label Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants