fix: type for resource look up[CNX-271]#778
Closed
Vikas Kumar (vikaskumr) wants to merge 3 commits into
Closed
Conversation
| } | ||
| [FunctionTypeEnum.ResourcesLookup]: { | ||
| event: ResourcesLookupRequest | ||
| context: FunctionEventManagementContext<P> & FunctionEventDeliveryContext<P> |
Contributor
There was a problem hiding this comment.
This should be | (see https://github.com/contentful/apps/pull/10142/files#r2395026825)
Suggested change
| context: FunctionEventManagementContext<P> & FunctionEventDeliveryContext<P> | |
| context: FunctionEventManagementContext<P> | FunctionEventDeliveryContext<P> |
Contributor
Author
There was a problem hiding this comment.
Yup, agreed already has the changes locally didn't pushed because issue is still the same, check comment here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have noticed there are more options available in delivery and management function context, this PR make sure all the necessary types are exposed in the handlers for the user to use it in any way.
Function Context for CDA/CPA
CMA