Export container healthcheck as LivenessProbe in generate kube

[givensuman]

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

• Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
  commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
  the sign-off email address. See CONTRIBUTING.md
  for more information.
• Referenced issues using Fixes: #00000 in commit message (if applicable)
• Tests have been added/updated (or no tests are needed)
• Documentation has been updated (or no documentation changes are needed)
• All commits pass make validatepr (format/lint checks)
• Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

This PR aims to supersede stale PR #28415 and close #22095, implementing maintainer comments.
If approved I plan to squash down the commits and add myself as co-signer.

[lsm5]

@givensuman (not a review) rebase on main to get past Mac OS arm64 issue.

[baude]

also, please consider squashing your commits and and running make validatepr to take care of some of the basic linting, etc.

[mheon]

This won't be generated, so do we need to include it?

[givensuman]

No, but now the tests are combined it makes sense to include for both.

[Honny1]

I have some comments. Also, don't forget to add a release note and Fixes: to commit msg.

[Honny1]

Suggested change

	Expect(probe.Exec.Command).To(ContainElement(ctr.healthCmdExpect))
	Expect(probe.Exec.Command).To(Equal([]string{"/bin/sh", "-c", "/bin/true"}))

[Honny1]

The healthCmdExpect should be []string. See my suggestion of assert. (It is not correct.)

[Honny1]

I would use switch something like this:

switch hc.Test[0] {
case define.HealthConfigTestCmd:
    cmd = hc.Test[1:]
case define.HealthConfigTestCmdShell:
    cmd = append([]string{"/bin/sh", "-c"}, hc.Test[1:]...)
default:
    return nil
}