Skip to content

machine: add vfkit timesync device for Apple VMs #28527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vyasgun wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −1
Open

machine: add vfkit timesync device for Apple VMs #28527

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a97ed3
machine: add vfkit timesync device for Apple VMs
vyasgun Apr 16, 2026
4e3b715
use constant for timesync port and update mac_env.sh to print krunkit…
vyasgun May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/machine/apple/apple.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,14 @@ func StartGenericAppleVM(mc *vmconfigs.MachineConfig, cmdBinary string, bootload
}
vm.Devices = append(vm.Devices, mounts...)

timesync, err := vfConfig.TimeSyncNew(1234)
Copy link
Copy Markdown
Member

@danishprakash danishprakash Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider using a named constant for the port

if err != nil {
return nil, nil, err
}
if err := vm.AddDevice(timesync); err != nil {
return nil, nil, err
}

// To start the VM, we need to call vfkit
cfg, err := config.Default()
if err != nil {
Expand Down