Make check_exists cache negative results as well as positive ones#580
Draft
Make check_exists cache negative results as well as positive ones#580
Conversation
Codecov Report
@@ Coverage Diff @@
## main #580 +/- ##
==========================================
- Coverage 83.47% 83.08% -0.40%
==========================================
Files 22 22
Lines 4502 4486 -16
Branches 1207 1239 +32
==========================================
- Hits 3758 3727 -31
- Misses 482 488 +6
- Partials 262 271 +9
|
mr-c
force-pushed
the
cache-negative-lookups
branch
from
c673535 to
8cdc65f
Compare
mr-c
force-pushed
the
cache-negative-lookups
branch
from
8cdc65f to
31d0117
Compare
Member
Author
|
FWIW while I believe this is still a useful optimization, it turned out redundant failed lookups was not a major performance issue for the particular workflow I was working on. |
When loading a workflow with URL references that can't be resolved, don't keep trying them over and over again. Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
mr-c
force-pushed
the
cache-negative-lookups
branch
from
e3271d5 to
6dbd430
Compare
mr-c
approved these changes
Sep 2, 2023
Member
mr-c
left a comment
mr-c
left a comment
There was a problem hiding this comment.
LGTM, can you take this out of draft?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading a workflow with URL references that can't be resolved,
don't keep trying them over and over again.