Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Engine/PhpGd/Helper/ResourceHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,9 @@ public function getContentsFromGdResource($format, $resource, array $options = [
break;
case PhpGdContext::FORMAT_JPEG:
$quality = isset($options['jpeg_quality']) ? $options['jpeg_quality'] : 100;
if (isset($options['jpeg_interlace'])) {
imageinterlace($resource, $options['jpeg_interlace']);
}
$success = @imagejpeg($resource, null, $quality);
break;
case PhpGdContext::FORMAT_GIF:
Expand Down
25 changes: 25 additions & 0 deletions src/OptionPass/JpegInterlaceOptionPass.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<?php

namespace Imagecraft\OptionPass;

/**
* @author Xianghan Wang <coldume@gmail.com>
* @since 1.0.0
*/
class JpegInterlaceOptionPass implements OptionPassInterface
{
/**
* @inheritDoc
*/
public function process(array $options)
{
if (
!isset($options['jpeg_interlace']) ||
!is_bool($options['jpeg_interlace'])
) {
$options['jpeg_interlace'] = false;
}

return $options;
}
}
31 changes: 31 additions & 0 deletions tests/OptionPass/JpegInterlaceOptionPassTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<?php

namespace Imagecraft\OptionPass;

/**
* @covers Imagecraft\OptionPass\JpegQualityOptionPass
*/
class JpegInterlaceOptionPassTest extends \PHPUnit_Framework_TestCase
{
protected $pass;

public function setUp()
{
$this->pass = $this->getMock('Imagecraft\\OptionPass\\JpegInterlaceOptionPass', null);
}

public function testProcess()
{
$option = $this->pass->process([]);
$this->assertEquals(false, $option['jpeg_interlace']);

$option = $this->pass->process(['jpeg_interlace' => true]);
$this->assertEquals(true, $option['jpeg_interlace']);

$option = $this->pass->process(['jpeg_interlace' => false]);
$this->assertEquals(false, $option['jpeg_interlace']);

$option = $this->pass->process(['jpeg_interlace' => 10]);
$this->assertEquals(false, $option['jpeg_interlace']);
}
}