Skip to content

feat: add explicit Node.js engine requirement to package.json#2667

Open
faisalnugroho wants to merge 2 commits into
coinbase:mainfrom
faisalnugroho:feat/add-node-engine-requirement
Open

feat: add explicit Node.js engine requirement to package.json#2667
faisalnugroho wants to merge 2 commits into
coinbase:mainfrom
faisalnugroho:feat/add-node-engine-requirement

Conversation

@faisalnugroho

Copy link
Copy Markdown

Summary\n\nAdds an explicit engines field to the root package.json specifying Node.js >= 22 and pnpm >= 10 requirements.\n\n## Changes\n\n- Added engines.node: ">=22" (aligned with existing .nvmrc)\n- Added engines.pnpm: ">=10" (aligned with packageManager field)\n\n## Motivation\n\nThe repository defines Node.js tooling through .nvmrc and package manager configuration, but does not expose an explicit engines requirement inside package.json. Adding this field improves contributor onboarding and makes version expectations clearer.\n\nCloses #2652

Add engines field to root package.json specifying Node.js >= 22 and
pnpm >= 10 requirements. This aligns with the existing .nvmrc config
and improves contributor onboarding by making version expectations
clear for local development and CI environments.

Closes coinbase#2652
@cb-heimdall

Copy link
Copy Markdown

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@vercel

vercel Bot commented May 28, 2026

Copy link
Copy Markdown

@faisalnugroho is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@faisalnugroho

Copy link
Copy Markdown
Author

Hi! Following up on this improvement PR. This PR adds an explicit Node.js engine requirement to package.json to prevent version mismatch issues that cause cryptic build errors.

All CI checks pass (StepSecurity ✅). Would love to get your review when you have a moment. Thanks!

@faisalnugroho

Copy link
Copy Markdown
Author

Hi! I'd love to get this PR reviewed when you have a moment. This PR addresses add explicit Node.js engine requirement. Happy to make any adjustments based on your feedback. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants