feat: add explicit Node.js engine requirement to package.json#2667
Open
faisalnugroho wants to merge 2 commits into
Open
feat: add explicit Node.js engine requirement to package.json#2667faisalnugroho wants to merge 2 commits into
faisalnugroho wants to merge 2 commits into
Conversation
Add engines field to root package.json specifying Node.js >= 22 and pnpm >= 10 requirements. This aligns with the existing .nvmrc config and improves contributor onboarding by making version expectations clear for local development and CI environments. Closes coinbase#2652
🟡 Heimdall Review Status
|
|
@faisalnugroho is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Hi! Following up on this improvement PR. This PR adds an explicit Node.js engine requirement to package.json to prevent version mismatch issues that cause cryptic build errors. All CI checks pass (StepSecurity ✅). Would love to get your review when you have a moment. Thanks! |
Author
|
Hi! I'd love to get this PR reviewed when you have a moment. This PR addresses add explicit Node.js engine requirement. Happy to make any adjustments based on your feedback. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\nAdds an explicit
enginesfield to the rootpackage.jsonspecifying Node.js >= 22 and pnpm >= 10 requirements.\n\n## Changes\n\n- Addedengines.node: ">=22"(aligned with existing.nvmrc)\n- Addedengines.pnpm: ">=10"(aligned withpackageManagerfield)\n\n## Motivation\n\nThe repository defines Node.js tooling through.nvmrcand package manager configuration, but does not expose an explicitenginesrequirement insidepackage.json. Adding this field improves contributor onboarding and makes version expectations clearer.\n\nCloses #2652