This repository was archived by the owner on May 26, 2025. It is now read-only.
Feature/221 counties reorder list#361
Open
Botosio wants to merge 8 commits intocode4romania:developfrom
Open
Conversation
Botosio
requested review from
Utwo,
aniri,
bogdanconstantinescu and
idormenco
as code owners
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/code4romania/monitorizare-vot-ong/6ofHvgQAvTWSGGKyJFQMtrsw7jVg |
idormenco
approved these changes
Oct 26, 2021
Member
|
lgtm |
Member
|
to be merged after backend issue code4romania/monitorizare-vot#388 is fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it fix?
Polling Station List can now be ordered by drag and drop or by "set to first" in the dropdown.
Delete now has a frontend call but backend is not completed yet.
Missing:
Icon to set to first:
Backend calls missing
Drag and drop takes the entire List
Delete and move-to-first uses 1 county to pass in.
All calls return a new list of counties.
Closes #221
@aniri hard to test until the backend is complete, URLs for the API can change to be whatever the backend dev wants.
How has it been tested?
Please drag and drop on an unfiltered polling station list.
Please click the dropdown and select delete
please click the dropdown and select "Set to first"
If you filter the list, drag, and drop will be disabled since the order doesn't have reference to all of the list.
Let me know if this is a must-have or not.