This repository was archived by the owner on May 26, 2025. It is now read-only.
Feature/mon vot 60 split#132
Draft
tbgdn wants to merge 18 commits intocode4romania:masterfrom
tbgdn:feature/mon-vot-60-split
Draft
Feature/mon vot 60 split#132tbgdn wants to merge 18 commits intocode4romania:masterfrom tbgdn:feature/mon-vot-60-split
tbgdn wants to merge 18 commits intocode4romania:masterfrom
tbgdn:feature/mon-vot-60-split
Conversation
Contributor
tbgdn
commented
Jun 29, 2019
tbgdn
commented
- Created smaller commits of the original PR
- Form sets and form sections can be added or deleted based on a mocked API that stores data in json files.
- Questions can be opened in view and edit modes, but the edit part is work in progress.
- The new EditableForms model is being used only for editing them, but it will be merged together with the existing one
This will allow the frontend to evolve independently of the API which at times might not provide the needed functionality. Once the API is done, this mock server can be removed.
Created a new mode that has the fields in English and which is used in the edit section of the application. Once the edit will be finished, the existing model will be merged with this new one.
Added the new link for the Forms page and created the routing for the component that displays the list of forms. At the moment, only the add functionality is working and clicking on the forms will not do anything.
Added component for displaying the sections of a Form and linked the routing to it.
Questions page can be opened in view or edit modes, but the edit does nothing for the moment.
# Conflicts: # frontend/package-lock.json # frontend/package.json # frontend/src/assets/i18n/en.json # frontend/src/assets/i18n/ro.json
Refactored some components to dumb them down and encapsulated the http calls from the effect to a separate service. Added functionality for ADD and DELETE on questions.
The text and the type of the question can be updated.
Made the id and text fields public, so they can be read.
Contributor
|
Please use this branch for future development: |
# Conflicts: # frontend/package-lock.json # frontend/package.json # frontend/proxy.conf.json # frontend/src/app/app.module.ts # frontend/src/app/models/form.model.ts # frontend/src/app/store/store.module.ts
# Conflicts: # frontend/package-lock.json # frontend/proxy.conf.json # frontend/src/app/app.module.ts # frontend/src/app/components/components.module.ts # frontend/src/app/components/login/login.component.ts # frontend/src/app/routing/app.routes.ts # frontend/src/app/store/store.module.ts # frontend/src/assets/i18n/en.json # frontend/src/assets/i18n/ro.json # frontend/src/styles.scss
# Conflicts: # frontend/package-lock.json # frontend/src/app/app.module.ts # frontend/src/app/components/components.module.ts # frontend/src/app/components/header/header.component.html # frontend/src/app/routing/app.routes.ts # frontend/src/assets/i18n/en.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.