Skip to content

add hybrid PU workflow to PR tests#51022

Open
kpedro88 wants to merge 2 commits into
cms-sw:masterfrom
kpedro88:Phase2-WF85
Open

add hybrid PU workflow to PR tests#51022
kpedro88 wants to merge 2 commits into
cms-sw:masterfrom
kpedro88:Phase2-WF85

Conversation

@kpedro88
Copy link
Copy Markdown
Contributor

PR description:

Now that the hybrid PU implementation is in the master branch (#50886), the workflow should be tested routinely. I have added one of the example workflows into the short matrix for PR tests.

I also dealt with these syntax warnings emitted by Python 3.12:

src/Configuration/PyReleaseValidation/python/WorkFlowRunner.py:71: SyntaxWarning: invalid escape sequence '\.'
  file_pattern_step = re.compile('file:step([1-9]+)(_[a-zA-Z]+)?\.[a-z]+')
src/Configuration/PyReleaseValidation/python/relval_steps.py:3889: SyntaxWarning: invalid escape sequence '\)'
  'extend_file_name(process.ALCARECOStreamPromptCalibProdSiPixelAliHLTHGC.fileName.value(), \\"_0\\"\"\)',
src/Configuration/PyReleaseValidation/python/relval_steps.py:3910: SyntaxWarning: invalid escape sequence '\)'
  'extend_file_name(process.ALCARECOStreamPromptCalibProdSiPixelAliHLTHGC.fileName.value(), \\"_1\\"\"\)',

(probably there should be a larger campaign to check for these; I only dealt with this one package)

attn: @civanch @subirsarkar @suchandradutta @bsunanda

PR validation:

runTheMatrix.py -l 17034.96 succeeds.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 22, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51022/49460

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @kpedro88 for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv)

@AdrianoDee, @DickyChant, @antoniovagnerini, @cmsbuild, @kfjack, @miquork, @sroychow can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @slomeo this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 84KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-740f94/53446/summary.html
COMMIT: 336b5ba
CMSSW: CMSSW_17_0_X_2026-05-22-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51022/53446/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4198477
  • DQMHistoTests: Total failures: 68
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4198389
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants