[EVOLUTION_X] Move sources of l1t::Calo{Cluster,Tower} inside io_v1 namespace

[makortel]

PR description:

To fix clang warnings in #50968 (comment)

Resolves cms-sw/framework-team#2247

PR validation:

Code compiles.

[cmsbuild]

cms-bot internal usage

[makortel]

Can't really test before #51011 gets in though Actually it can be tested against the latest EVOLUTION_X IB.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51016/49444

ERROR: Build errors found during clang-tidy run.

   12 |   void CaloCluster::setClusterFlag(ClusterFlag flag, bool val) {
      |        ~~~~~~~~~~~~~^
src/DataFormats/L1TCalorimeter/src/CaloCluster.cc:13:9: error: use of undeclared identifier 'val' [clang-diagnostic-error]
   13 |     if (val) {
      |         ^~~
src/DataFormats/L1TCalorimeter/src/CaloCluster.cc:14:7: error: use of undeclared identifier 'm_clusterFlags' [clang-diagnostic-error]
   14 |       m_clusterFlags |= (0x1 << flag);
      |       ^~~~~~~~~~~~~~
src/DataFormats/L1TCalorimeter/src/CaloCluster.cc:14:33: error: use of undeclared identifier 'flag' [clang-diagnostic-error]
   14 |       m_clusterFlags |= (0x1 << flag);
      |                                 ^~~~
src/DataFormats/L1TCalorimeter/src/CaloCluster.cc:16:7: error: use of undeclared identifier 'm_clusterFlags' [clang-diagnostic-error]
   16 |       m_clusterFlags &= ~(0x1 << flag);
      |       ^~~~~~~~~~~~~~
src/DataFormats/L1TCalorimeter/src/CaloCluster.cc:16:34: error: use of undeclared identifier 'flag' [clang-diagnostic-error]
   16 |       m_clusterFlags &= ~(0x1 << flag);
      |                                  ^~~~
src/DataFormats/L1TCalorimeter/src/CaloCluster.cc:20:8: error: use of undeclared identifier 'CaloCluster'; did you mean 'l1t::CaloCluster'? [clang-diagnostic-error]
   20 |   void CaloCluster::setHwPtEm(int pt) { m_hwPtEm = pt; }
      |        ^~~~~~~~~~~
      |        l1t::CaloCluster
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[makortel]

type evolution

[makortel]

assign core

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51016/49447

ERROR: Build errors found during clang-tidy run.

   20 |         hwEtRatio_(hwEtRatio) {}
      |                    ^~~~~~~~~
      |                    l1t::io_v1::CaloTower::hwEtRatio
--
src/DataFormats/L1TCalorimeter/src/CaloTower.cc:22:3: error: use of undeclared identifier 'CaloTower'; did you mean 'l1t::CaloTower'? [clang-diagnostic-error]
   22 |   CaloTower::~CaloTower() {}
      |   ^~~~~~~~~
      |   l1t::CaloTower
--
src/DataFormats/L1TCalorimeter/src/CaloTower.cc:22:14: error: cannot define or redeclare '~CaloTower' here because namespace 'io_v1' does not enclose namespace 'CaloTower' [clang-diagnostic-error]
   22 |   CaloTower::~CaloTower() {}
      |   ~~~~~~~~~~~^
src/DataFormats/L1TCalorimeter/src/CaloTower.cc:24:8: error: use of undeclared identifier 'CaloTower'; did you mean 'l1t::CaloTower'? [clang-diagnostic-error]
   24 |   void CaloTower::setEtEm(double et) { etEm_ = et; }
      |        ^~~~~~~~~
      |        l1t::CaloTower
--
src/DataFormats/L1TCalorimeter/src/CaloTower.cc:24:19: error: cannot define or redeclare 'setEtEm' here because namespace 'io_v1' does not enclose namespace 'CaloTower' [clang-diagnostic-error]
   24 |   void CaloTower::setEtEm(double et) { etEm_ = et; }
      |        ~~~~~~~~~~~^
Suppressed 489 warnings (489 in non-user code).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51016/49448

[cmsbuild]

New categories assigned: core

@Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

A new Pull Request was created by @makortel for CMSSW_17_0_EVOLUTION_X.

It involves the following packages:

• DataFormats/L1TCalorimeter (l1)

@BenjaminRS, @Dr15Jones, @cmsbuild, @makortel, @quinnanm, @smuzaffar can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f69fa9/53440/summary.html
COMMIT: b469d6e
CMSSW: CMSSW_17_0_EVOLUTION_X_2026-05-18-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51016/53440/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

[makortel]

+core

[makortel]

hold

I think we shouldn't merge this until #51011 has been resolved

[cmsbuild]

Pull request has been put on hold by @makortel
They need to issue an unhold command to remove the hold state or L1 can unhold it for all