Skip to content

[VISUALIZATION] [GCC16] cleanup for unused variables #50989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
smuzaffar wants to merge 1 commit into from
Closed

[VISUALIZATION] [GCC16] cleanup for unused variables #50989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Fireworks/Core/src/CmsShowCommon.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,9 @@ void CmsShowCommon::permuteColors() {
void CmsShowCommon::randomizeColors() {
// printf("Doing random_shuffle on existing colors ...\n");

int vi = 0;
for (FWEventItemsManager::const_iterator i = m_context->eventItemsManager()->begin();
i != m_context->eventItemsManager()->end();
++i, ++vi) {
++i) {
FWDisplayProperties prop = (*i)->defaultDisplayProperties();

int col = rand() % 17; // randomize in first row of palette
Expand Down
5 changes: 2 additions & 3 deletions Fireworks/Core/src/FWModelChangeManager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,8 @@ void FWModelChangeManager::endChanges() {
//makes sure that 'changeSignalsAreDone is called if changeSignalsAreComing_ is sent
bool guard(false);
if (0 == --m_depth) {
unsigned int index = 0;
for (std::set<const FWEventItem*>::iterator itChanges = m_itemChanges.begin(); itChanges != m_itemChanges.end();
++itChanges, ++index) {
++itChanges) {
if (!guard) {
// std::shared_ptr<FWModelChangeManager> done(this, &sendChangeSignalsAreDone);
guard = true;
Expand All @@ -109,7 +108,7 @@ void FWModelChangeManager::endChanges() {
}
m_itemChanges.clear();

for (size_t ci = 0, ce = m_changes.size(), si = 0; ci != ce; ++ci, ++si) {
for (size_t ci = 0, ce = m_changes.size(); ci != ce; ++ci) {
FWModelIds& changes = m_changes[ci];
if (not changes.empty()) {
if (!guard) {
Expand Down
3 changes: 1 addition & 2 deletions Fireworks/ParticleFlow/plugins/FWPFCandidateWithHitsProxyBuilder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,9 @@ void FWPFCandidateWithHitsProxyBuilder::build(const FWEventItem* iItem,
if (candidates == nullptr)
return;

Int_t idx = 0;
initPFRecHitsCollections();
for (reco::PFCandidateCollection::const_iterator it = candidates->begin(), itEnd = candidates->end(); it != itEnd;
++it, ++idx) {
++it) {
TEveCompound* comp = createCompound();
setupAddElement(comp, product);
// printf("products size %d/%d \n", (int)iItem->size(), product->NumChildren());
Expand Down