Skip to content

Fix searchInCommands option for runTheMatrix.py --interactive#50977

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
cms-ngt-hlt:mm_fix_searchInCommands
May 20, 2026
Merged

Fix searchInCommands option for runTheMatrix.py --interactive#50977
cmsbuild merged 1 commit into
cms-sw:masterfrom
cms-ngt-hlt:mm_fix_searchInCommands

Conversation

@mmusich
Copy link
Copy Markdown
Contributor

@mmusich mmusich commented May 19, 2026

PR description:

Title says it all.
Before this PR:

searchInCommands standard .* .*HLT:HIon.*
Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc13/cms/cmssw/CMSSW_17_0_X_2026-05-18-2300/bin/el8_amd64_gcc13/runTheMatrix.py", line 1040, in <module>
    TheMatrix(opt).cmdloop()
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc13/external/python3/3.12.4-1d56c354f154d4b4623813614af4d338/lib/python3.12/cmd.py", line 138, in cmdloop
    stop = self.onecmd(line)
           ^^^^^^^^^^^^^^^^^
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc13/external/python3/3.12.4-1d56c354f154d4b4623813614af4d338/lib/python3.12/cmd.py", line 217, in onecmd
    return func(arg)
           ^^^^^^^^^
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc13/cms/cmssw/CMSSW_17_0_X_2026-05-18-2300/bin/el8_amd64_gcc13/runTheMatrix.py", line 872, in do_searchInCommands
    if re.match(pattern_command, command):
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc13/external/python3/3.12.4-1d56c354f154d4b4623813614af4d338/lib/python3.12/re/__init__.py", line 167, in match
    return _compile(pattern, flags).match(string)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: expected string or bytes-like object, got 'InputInfo'

This is likely a regression introduced by Python 3.12 becoming stricter about regex argument types.

Additionally I include a test case for searchInCommands in test-runTheMatrix_interactive.

PR validation:

scram b runtests_test-runTheMatrix-interactive runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

- include a test case for searchInCommands in test-runTheMatrix_interactive
@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented May 19, 2026

type bug-fix

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 19, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50977/49384

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv)

@AdrianoDee, @DickyChant, @antoniovagnerini, @cmsbuild, @kfjack, @miquork, @sroychow can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @slomeo this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented May 19, 2026

@rovere FYI

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented May 19, 2026

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a3bb9/53323/summary.html
COMMIT: 2aa6fd6
CMSSW: CMSSW_17_0_X_2026-05-18-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50977/53323/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4187292
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4187263
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link
Copy Markdown
Contributor

+pdmv

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit bff5a0d into cms-sw:master May 20, 2026
10 checks passed
@mmusich mmusich deleted the mm_fix_searchInCommands branch May 20, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants