Skip to content

Increase layer number for HCAL validation.#50929

Merged
cmsbuild merged 2 commits into
cms-sw:masterfrom
bfonta:bugfix/asan_outofbounds
May 16, 2026
Merged

Increase layer number for HCAL validation.#50929
cmsbuild merged 2 commits into
cms-sw:masterfrom
bfonta:bugfix/asan_outofbounds

Conversation

@bfonta
Copy link
Copy Markdown
Contributor

@bfonta bfonta commented May 13, 2026

Resolves #50884.

Tested with runTheMatrix.py -l 34434.758 -w upgrade on top of CMSSW_17_0_ASAN_X_2026-05-04-2300.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 13, 2026

cms-bot internal usage

@bfonta
Copy link
Copy Markdown
Contributor Author

bfonta commented May 13, 2026

type ngt

@cmsbuild
Copy link
Copy Markdown
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50929/49320

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50929/49321

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @bfonta for master.

It involves the following packages:

  • Validation/HGCalValidation (dqm)

@cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@apsallid, @bsunanda, @cseez, @denizsun, @hatakeyamak, @lecriste, @lgray, @pfs, @rovere, @salimcerci, @sethzenz, @vandreev11 this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Copy Markdown
Contributor

please test workflow 34434.771,34434.758 for CMSSW_17_0_ASAN_X

@smuzaffar
Copy link
Copy Markdown
Contributor

please test workflow 34434.771,34434.758

@bfonta
Copy link
Copy Markdown
Contributor Author

bfonta commented May 13, 2026

@smuzaffar I noticed that there was a wrong comment on the previous commit. Could you please re-run the tests?

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented May 13, 2026

type bug-fix

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50929/49322

@smuzaffar
Copy link
Copy Markdown
Contributor

please test workflow 34434.771,34434.758 for CMSSW_17_0_ASAN_X

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #50929 was updated. @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please check and sign again.

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented May 13, 2026

@brusale FYI

@smuzaffar
Copy link
Copy Markdown
Contributor

please test workflow 34434.771,34434.758

lets run the normal/default PR tests too

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e3c9a/53227/summary.html
COMMIT: 670b9f4
CMSSW: CMSSW_17_0_X_2026-05-12-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50929/53227/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 55
  • DQMHistoTests: Total histograms compared: 4250219
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 168
  • DQMHistoTests: Total successes: 4250031
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 100.138 KiB( 54 files compared)
  • DQMHistoSizes: changed ( 34434.758,... ): 50.069 KiB HLT/BarrelCalorimeters
  • Checked 233 log files, 201 edm output root files, 55 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e3c9a/53222/summary.html
COMMIT: 670b9f4
CMSSW: CMSSW_17_0_ASAN_X_2026-05-11-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50929/53222/install.sh to create a dev area with all the needed externals and cmssw changes.

@smuzaffar
Copy link
Copy Markdown
Contributor

@gabrielmscampos
Copy link
Copy Markdown
Member

+dqm

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 6c58047 into cms-sw:master May 16, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ASAN] heap-buffer-overflow in BarrelVHistoProducerAlgo::fill_simCluster_histos()

6 participants