Skip to content

Removing default/invalid (-999 ns) HCAL rechit timings from HCAL PF cluster time calculation #50910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gk199 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Removing default/invalid (-999 ns) HCAL rechit timings from HCAL PF cluster time calculation #50910

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e65be2a
adding if statements to prevent default time rechits averaged in to P…
gk199 May 5, 2026
556383c
replacing line accidentally removed
gk199 May 5, 2026
7ddff00
code format changes applied
gk199 May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions RecoParticleFlow/PFClusterProducer/plugins/Basic2DGenericPFlowPositionCalc.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,12 +179,16 @@ void Basic2DGenericPFlowPositionCalc::calculateAndSetPositionActual(reco::PFClus
int cell_layer = (int)refhit.layer();
res2 = isBarrel(cell_layer) ? 1. / _timeResolutionCalcBarrel->timeResolution2(rh_rawenergy)
: 1. / _timeResolutionCalcEndcap->timeResolution2(rh_rawenergy);
cl_time += rh_fraction * refhit.time() * res2;
cl_timeweight += rh_fraction * res2;
if (refhit.time() != -999) {
cl_time += rh_fraction * refhit.time() * res2;
cl_timeweight += rh_fraction * res2;
}
} else { // assume resolution = 1/E**2
const double rh_rawenergy2 = rh_rawenergy * rh_rawenergy;
cl_timeweight += rh_rawenergy2 * rh_fraction;
cl_time += rh_rawenergy2 * rh_fraction * refhit.time();
if (refhit.time() != -999) {
cl_timeweight += rh_rawenergy2 * rh_fraction;
cl_time += rh_rawenergy2 * rh_fraction * refhit.time();
}
}

if (rh_energy > max_e) {
Expand All @@ -194,7 +198,10 @@ void Basic2DGenericPFlowPositionCalc::calculateAndSetPositionActual(reco::PFClus
}

cluster.setEnergy(cl_energy);
cluster.setTime(cl_time / cl_timeweight);
if (cl_timeweight == 0)
cluster.setTime(-999); // means no cells with valid timing in the cluster -- thus, report default time
else
cluster.setTime(cl_time / cl_timeweight);
if (resGiven) {
cluster.setTimeError(std::sqrt(1.0f / float(cl_timeweight)));
}
Expand Down