Gtt jet finding geometry readout

[ccahoughton]

PR description:

• Added valid bit to TkJetWord object
• TkJetWord now contains 64 bits of data as opposed to 63 before
• Changed track jet ordering on readout to GTT pattern file to reflect the same order as the firmware (was sorted by pT before, now sorted first by phi then by eta)
• Added extra output file when running createFirmwareInputFiles_cfg.py called FirmwareGeometryFile.vh. If any of the JetFinding parameters change like eta bin centers or cuts on track multiplicity, regenerate FirmwareGeometryFile.vh and place it in the /algo/components/jet/firmware/hdl/ directory of the JetFinding firmware.
• Presentation of changes in a talk coming soon

PR validation:

• Valid bit present in track jet words in GTT test vector files
• Used FirmwareGeometryFile.vh in the firmware and checked emulator test vector output against firmware. They match.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50908/49269

• There are other open Pull requests which might conflict with changes you have proposed:
  • File L1Trigger/DemonstratorTools/test/gtt/createFirmwareInputFiles_cfg.py modified in PR(s): W3Pi Emulation and Test Vectors #49003

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50908/49269/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50908/49269/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50908/49271

• There are other open Pull requests which might conflict with changes you have proposed:
  • File L1Trigger/DemonstratorTools/test/gtt/createFirmwareInputFiles_cfg.py modified in PR(s): W3Pi Emulation and Test Vectors #49003

[cmsbuild]

A new Pull Request was created by @ccahoughton for master.

It involves the following packages:

• DataFormats/L1Trigger (l1)
• L1Trigger/DemonstratorTools (l1)
• L1Trigger/L1TTrackMatch (l1)

@BenjaminRS, @cmsbuild, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @eyigitba, @missirol, @mmusich, @rovere, @thomreis this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[quinnanm]

please test

[cmsbuild]

+1

Size: This PR adds an extra 48KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cf094/53153/summary.html
COMMIT: 8bc438b
CMSSW: CMSSW_17_0_X_2026-05-08-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50908/53153/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 53
• DQMHistoTests: Total histograms compared: 4187168
• DQMHistoTests: Total failures: 60
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4187088
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
• Checked 227 log files, 197 edm output root files, 53 DQM output files
• TriggerResults: no differences found

[BenjaminRS]

Hi Connor - to let you know. PR #49003 will soon be closed and this also modified L1Trigger/DemonstratorTools/test/gtt/createFirmwareInputFiles_cfg.py. So I suggest we wait until that one is in and we will ask you to rebase on-top of that PR. In the mean time we can review the other files modified.