Uniform vertex distribution in a R and ϕ range.#50904
Conversation
|
type ngt |
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50904/49260 |
|
A new Pull Request was created by @bfonta for master. It involves the following packages:
@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
fb1e0a9 to
f88c9f4
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50904/49297 |
|
I've updated the description with the addition of new displaced workflows. |
|
test parameters:
|
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 60KB to repository DAS Queries: The DAS query tests failed, see the summary page for details. Comparison SummarySummary:
|
|
+pdmv |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
@bfonta , some relvals are failing in latest 17.0.X Ibs with error [a]. Could the change in this PR is causing (or added checks to capture ) those failures? |
it should be fixed at #50946 |
mmusich
left a comment
There was a problem hiding this comment.
while reading the class I have a couple of other comments.
PR description
Enables the uniform distribution of vertices along$R=\sqrt{x^2+y^2}$ .$z$ coordinate (cylindrical coordinates).$R$ .
The user can also control the location of the vertices along the azimuthal angle and the
Useful for generating particle guns with a displaced vertex, in order to e.g. study the performance of reconstruction algorithms as a function of
Resolves #50895.
PR validation:
Run the
GEN-SIMof the34402.0 SingleElectronPt35+Run4D121workflow, but modify its configuration file by adding:Then run the step (
cmsRun SingleElectronPt35_pythia8_cfi_GEN_SIM.py), and inspect its output with:Then run the second step:
cmsDriver.py step2 -s DIGI:pdigi_valid,L1TrackTrigger,L1,L1P2GT,DIGI2RAW,HLT:@relvalRun4 --conditions auto:phase2_realistic_T35 --datatier GEN-SIM-DIGI-RAW -n ${NEVENTS} --eventcontent FEVTDEBUGHLT --geometry ExtendedRun4D121 --era Phase2C22I13M9 --filein file:step1.root --fileout file:step2.rootand visualize its output with$R=10$ and $R=20$ , and the primary vertex was located at the expected distance from the centre of the detector (for instance, for $R=20$ it was always located just beyond the last pixel barrel layer).
cmsShow(link). I did it forUpdate:
I've added a new workflow class (
_displacedVertex) for the workflow to be directly testable in this PR plus being easily accessible by all users. The displaced vertex is now available for allSingleGammaandSingleElectronworkflows. The vertex is changed via the--beamspotoption.Example:
34401.82 SingleElectronPt10+Run4D121_displacedVertex: