Skip to content

[NGT] Fix content of SiPixelClusterSoA for empty Pixel Detector #50900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 2 commits into from
May 12, 2026
Merged

[NGT] Fix content of SiPixelClusterSoA for empty Pixel Detector #50900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9c2bb7
Fix filling of SiPixelClusterSoA in event with empty pixel tracker
JanGerritSchulz May 7, 2026
76fdaaf
Set number of active modules, clusters and offsets in Digi/ClusterSoA…
JanGerritSchulz May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelPhase2DigiToCluster.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,10 @@ namespace ALPAKA_ACCELERATOR_NAMESPACE {
}
digis_d_ = SiPixelDigisSoACollection(iEvent.queue(), nDigis_);

if (nDigis_ == 0)
if (nDigis_ == 0) {
algo_.zeroInitializePhase2Clusters(iEvent.queue());
return;
}

SiPixelDigisHost digis_h(iEvent.queue(), nDigis_);

Expand Down Expand Up @@ -170,14 +172,11 @@ namespace ALPAKA_ACCELERATOR_NAMESPACE {
}

void SiPixelPhase2DigiToCluster::produce(device::Event& iEvent, device::EventSetup const& iSetup) {
if (nDigis_ == 0) {
iEvent.emplace(digiPutToken_, std::move(*digis_d_));
iEvent.emplace(clusterPutToken_, iEvent.queue(), pixelTopology::Phase2::numberOfModules);
} else {
if (nDigis_ != 0)
digis_d_->setNModules(algo_.nModules());
iEvent.emplace(digiPutToken_, std::move(*digis_d_));
iEvent.emplace(clusterPutToken_, algo_.getClusters());
}

iEvent.emplace(digiPutToken_, std::move(*digis_d_));
iEvent.emplace(clusterPutToken_, algo_.getClusters());
digis_d_.reset();
}

Expand Down
13 changes: 13 additions & 0 deletions RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelRawToClusterKernel.dev.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,6 +771,19 @@ namespace ALPAKA_ACCELERATOR_NAMESPACE {
#endif
} //

// Function to zero-initialize the clusters
template <typename TrackerTraits>
void SiPixelRawToClusterKernel<TrackerTraits>::zeroInitializePhase2Clusters(Queue &queue) {
constexpr int numberOfModules = pixelTopology::Phase2::numberOfModules;
clusters_d = SiPixelClustersSoACollection(queue, numberOfModules);
clusters_d->zeroInitialise(queue);
// set moduleStartFirstElement, moduleStartLastElement and bpix2ClusterStart on the host to zero
// these changes are later propagated to the device portable collection during getDigis() and getClusters()
nModules_Clusters_h[0] = 0;
nModules_Clusters_h[1] = 0;
nModules_Clusters_h[2] = 0;
}

template class SiPixelRawToClusterKernel<pixelTopology::Phase1>;
template class SiPixelRawToClusterKernel<pixelTopology::Phase2>;
template class SiPixelRawToClusterKernel<pixelTopology::HIonPhase1>;
Expand Down
2 changes: 2 additions & 0 deletions RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelRawToClusterKernel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,8 @@ namespace ALPAKA_ACCELERATOR_NAMESPACE {
const uint32_t numDigis,
const uint32_t offsetBPIX2);

void zeroInitializePhase2Clusters(Queue& queue);

SiPixelDigisSoACollection getDigis() {
digis_d->setNModules(nModules_Clusters_h[0]);
return std::move(*digis_d);
Expand Down